[
https://issues.apache.org/jira/browse/TINKERPOP-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15215218#comment-15215218
]
ASF GitHub Bot commented on TINKERPOP-1016:
-------------------------------------------
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/274#issuecomment-202656792
VOTE +1 - benchmarks ran for me without issue now. Not a big deal, but I
noticed that i have to be in the gremlin-benchmark directory to do: `mvn test
-DskipBenchmarks=false` or else i get an error which makes sense because
gremlin-shaded won't build properly on the "test" target. Anyway, maybe
something to document after merge.
> Replace junit-benchmarks with JMH
> ---------------------------------
>
> Key: TINKERPOP-1016
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1016
> Project: TinkerPop
> Issue Type: Improvement
> Components: test-suite
> Affects Versions: 3.1.0-incubating
> Reporter: Ted Wilmes
> Assignee: Ted Wilmes
> Priority: Minor
>
> Replace junit-benchmark with JMH. This includes the following tasks:
> * Evaluate which existing benchmarks should be kept and port them to JMH.
> * Add an initial JMH benchmark for TINKERPOP-957
> * See if we can trigger perf tests with the same scheme that is currently
> used {noformat}mvn verify -DskipPerformanceTests=true/false{noformat}
> * Write developer docs that outline our initial performance testing approach.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
