[
https://issues.apache.org/jira/browse/TINKERPOP-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15205234#comment-15205234
]
ASF GitHub Bot commented on TINKERPOP-1016:
-------------------------------------------
GitHub user twilmes opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/274
TINKERPOP-1016 Replace junit-benchmarks with JMH
This PR includes the following:
- deprecates JUnit benchmark performance tests and added notes to the
3.2.0 upgrade docs (the deprecation vs. outright deletion may be overkill but I
thought that some providers may still be using these)
- adds a new JMH gremlin-benchmark module with basic starter benchmarks.
These benchmarks are meant to be used for internal TinkerPop benchmarking
purposes as opposed to provider benchmarking
- added a `Developing Benchmarks` section to the developer docs
You can run the benchmarks both from your IDE and maven. They are nested
inside of a JUnit test runner. In addition, a benchmark uber-jar can be built
and benchmarks can be run using the built-in JMH test runner:
`java -jar gremlin-benchmark-3.2.0-SNAPSHOT.jar`
By default, benchmark output is stored in JSON format in a benchmark
directory. To run the benchmarks from maven do `mvn test
-DskipBenchmarks=false`.
`mvn clean install` and `./processDocs.sh --dryRun` checked out ok.
VOTE: +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-1016
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/274.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #274
----
commit 154a12b1c8be1052c0ed56e4a7e28032da5e5bc5
Author: Ted Wilmes <[email protected]>
Date: 2016-03-21T18:22:09Z
This commit includes the following:
* added new gremlin-benchmark module and initial benchmark classes
* deprecated the JUnit benchmark classes, noted this deprecation in upgrade
doc
* expanded scope of LoadGraphWith annotation to allow for class level
annotation
* added developer benchmarking documentation
commit cd4d9ccc9f0d46e20fc441fb39f85b53ac8eebff
Author: Ted Wilmes <[email protected]>
Date: 2016-03-21T21:19:48Z
Added gremlin-benchmark pom.xml to module and updated javadocs.
----
> Replace junit-benchmarks with JMH
> ---------------------------------
>
> Key: TINKERPOP-1016
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1016
> Project: TinkerPop
> Issue Type: Improvement
> Components: test-suite
> Affects Versions: 3.1.0-incubating
> Reporter: Ted Wilmes
> Assignee: Ted Wilmes
> Priority: Minor
>
> Replace junit-benchmark with JMH. This includes the following tasks:
> * Evaluate which existing benchmarks should be kept and port them to JMH.
> * Add an initial JMH benchmark for TINKERPOP-957
> * See if we can trigger perf tests with the same scheme that is currently
> used {noformat}mvn verify -DskipPerformanceTests=true/false{noformat}
> * Write developer docs that outline our initial performance testing approach.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
