[
https://issues.apache.org/jira/browse/TINKERPOP-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155606#comment-15155606
]
ASF GitHub Bot commented on TINKERPOP-1041:
-------------------------------------------
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/209#issuecomment-186588044
You quoted the javadoc there and that's precisely my point about something
looking wrong. If my interpretation of that javadoc and the java source code
is correct, `awaitTermination` is returning false after blocking (due to
timeout), and you are just sleeping the thread for 30 seconds. which is plenty
of time for that work to finish. then you call a hard `shutdownNow` which has
no effect really because there are no more tasks executed. `awaitTermintation`
requires a call to `shutdown` somewhere for it to ever return true (success).
if this was a problem for appveyor I suggest you update your branch with
the latest changes which should have fixed the problems we were seeing with
this test:
https://github.com/apache/incubator-tinkerpop/blob/tp31/gremlin-groovy/src/test/java/org/apache/tinkerpop/gremlin/groovy/engine/GremlinExecutorTest.java#L634-L638
Let's see if appveyor is happy with that change before we go to merge this.
> StructureStandardTestSuite has file I/O issues on Windows
> ---------------------------------------------------------
>
> Key: TINKERPOP-1041
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1041
> Project: TinkerPop
> Issue Type: Bug
> Components: test-suite
> Affects Versions: 3.0.2-incubating
> Environment: Windows 10, Java 8, TinkerPop version "3.0.2-incubating"
> Reporter: Martin Häusler
> Assignee: Jason Plurad
> Fix For: 3.1.2-incubating
>
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> Most of the tests in StructureStandardTestSuite/IoGraphTest cause an
> unexpected java.io.IOException. The stack trace looks like this:
> {panel:title=Stack Trace}
> java.io.IOException: The the file name, directory name or volume label syntax
> is incorrect.
> at java.io.WinNTFileSystem.createFileExclusively(Native Method)
> at java.io.File.createTempFile(Unknown Source)
> at
> org.apache.tinkerpop.gremlin.TestHelper.generateTempFile(TestHelper.java:74)
> at
> org.apache.tinkerpop.gremlin.structure.io.IoGraphTest.shouldReadWriteModernToFileWithHelpers(IoGraphTest.java:164)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> {panel}
> I'm running the test suite from Eclipse under Java 8, on a Windows 10 x64
> machine. The dependencies in my project are managed with gradle.
> Investigating the offinsive line
> (org.apache.tinkerpop.gremlin.TestHelper.java@74) in the debugger reveals the
> following parameters of "File.createTempFile(...)":
> {noformat}
> fileName = "shouldReadWriteModernToFileWithHelpers[graphml]"
> fileNameSuffix = ".xml"
> path =
> "file:\D:\guh\caches\modules-2\files-2.1\org.apache.tinkerpop\gremlin-test\3.0.2-incubating\345ec87b74923b76374111f2e4040d4d105f256\temp"
> {noformat}
> The offensive part is the "path" variable, because it contains the prefix
> "file:\". I tried the same thing in a dedicated JUnit test without the prefix
> and it works fine.
> I would be very happy to see this issue fixed, as this considerably reduces
> the amount of tests in the suite that I can run against my graph
> implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
