[
https://issues.apache.org/jira/browse/TINKERPOP-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154248#comment-15154248
]
ASF GitHub Bot commented on TINKERPOP-1041:
-------------------------------------------
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/209#issuecomment-186226747
I've grown suspicious of this line:
https://github.com/apache/incubator-tinkerpop/pull/209/files#diff-8ae08149638a77bbb943e6bb8438cfb6R631
because you `awaitTermination` without calling `shutdown` first. Calling
`shutdownNow` after it doesn't indicate an orderly shutdown either and nothing
is done with the list of returned un-executed tasks....
that said, I don't think it really matters though because we actually got
that test much more stable on the `tp31` line since you originally branched
this. I just wanted to bring those points to your attention in case you had
comments. When I merge your branch to tp31 locally, those lines you added go
away.
I had some failures with integration tests last night, but solved the
problem this morning (bug in the latest tp31 branch). I'll need to re-run the
tests gain in full tonight after that fix. If all works, I can vote positively
tomorrow.
> StructureStandardTestSuite has file I/O issues on Windows
> ---------------------------------------------------------
>
> Key: TINKERPOP-1041
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1041
> Project: TinkerPop
> Issue Type: Bug
> Components: test-suite
> Affects Versions: 3.0.2-incubating
> Environment: Windows 10, Java 8, TinkerPop version "3.0.2-incubating"
> Reporter: Martin Häusler
> Assignee: Jason Plurad
> Fix For: 3.1.2-incubating
>
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> Most of the tests in StructureStandardTestSuite/IoGraphTest cause an
> unexpected java.io.IOException. The stack trace looks like this:
> {panel:title=Stack Trace}
> java.io.IOException: The the file name, directory name or volume label syntax
> is incorrect.
> at java.io.WinNTFileSystem.createFileExclusively(Native Method)
> at java.io.File.createTempFile(Unknown Source)
> at
> org.apache.tinkerpop.gremlin.TestHelper.generateTempFile(TestHelper.java:74)
> at
> org.apache.tinkerpop.gremlin.structure.io.IoGraphTest.shouldReadWriteModernToFileWithHelpers(IoGraphTest.java:164)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> {panel}
> I'm running the test suite from Eclipse under Java 8, on a Windows 10 x64
> machine. The dependencies in my project are managed with gradle.
> Investigating the offinsive line
> (org.apache.tinkerpop.gremlin.TestHelper.java@74) in the debugger reveals the
> following parameters of "File.createTempFile(...)":
> {noformat}
> fileName = "shouldReadWriteModernToFileWithHelpers[graphml]"
> fileNameSuffix = ".xml"
> path =
> "file:\D:\guh\caches\modules-2\files-2.1\org.apache.tinkerpop\gremlin-test\3.0.2-incubating\345ec87b74923b76374111f2e4040d4d105f256\temp"
> {noformat}
> The offensive part is the "path" variable, because it contains the prefix
> "file:\". I tried the same thing in a dedicated JUnit test without the prefix
> and it works fine.
> I would be very happy to see this issue fixed, as this considerably reduces
> the amount of tests in the suite that I can run against my graph
> implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
