We could add (yet) another Github workflow validation. Or maybe take the Docker one, which looks at certain paths (including bin/solr), and generalizes to be not just testing docker but also running BATS integration tests. Then think of this as the "integration test" build. The "paths" it looks at could be expanded to include some of the Java source CLI patterns so this runs in more cases that are likely to be impacted.
I'm slightly reluctant to take the Crave build and slow it down to run those integration tests that run serially. It's amazing, particularly when working locally, to get fast feedback on all Java based tests. Admittedly it's not an either-or; it's a matter of indicating the desired targets in the build, so I shouldn't be reluctant here. Anyway, I'm more keen to expand the scope of the Docker build. On Thu, Jun 6, 2024 at 9:17 AM Eric Pugh <ep...@opensourceconnections.com> wrote: > > I think a weekly heads up would be great to have. > > You mention “PR validation doesn’t run BATS tests”…. Maybe it should? > We’ve had a lot of churn in the CLI, and we’ll probably continue to have that > till 10x comes out, so that would be a nice check. Plus, if we add more > integration style BATS tests, why not have them be run on the PR’s? > > > On May 31, 2024, at 11:40 AM, David Smiley <dsmi...@apache.org> wrote: > > > > I'm concerned that too few people look at the bui...@solr.apache.org > > From time to time I go look but we have no notifications other than > > emailing that list. > > > > If hypothetically nobody looked, we might as well not have CI at all; > > we'd only have PR based validation. We'd lose out on historic test > > failure tracking and detection of introducing a problem that got > > merged anyway. PR validation doesn't run BATS tests or "Nightly" > > tests. > > > > Long ago, I recall getting a direct email to me if I contributed a > > change to a CI failure. I would like this. I would also like a dev > > list email periodically (weekly?) listing the CI job status. > > > > Any opinions on what to do here? > > > > ~ David Smiley > > Apache Lucene/Solr Search Developer > > http://www.linkedin.com/in/davidwsmiley > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org > > For additional commands, e-mail: dev-h...@solr.apache.org > > > > _______________________ > Eric Pugh | Founder | OpenSource Connections, LLC | 434.466.1467 | > http://www.opensourceconnections.com <http://www.opensourceconnections.com/> > | My Free/Busy <http://tinyurl.com/eric-cal> > Co-Author: Apache Solr Enterprise Search Server, 3rd Ed > <https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw> > This e-mail and all contents, including attachments, is considered to be > Company Confidential unless explicitly stated otherwise, regardless of > whether attachments are marked as such. > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org For additional commands, e-mail: dev-h...@solr.apache.org
