[
https://issues.apache.org/jira/browse/PIO-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16010728#comment-16010728
]
ASF GitHub Bot commented on PIO-64:
-----------------------------------
Github user EmergentOrder commented on the issue:
https://github.com/apache/incubator-predictionio/pull/382
This change looks good to me. Agree that it is wrong to set creation time
to event time, and this should bring behavior back in line with that of HBase.
> JDBCPEvents unit tests fail intermittently
> ------------------------------------------
>
> Key: PIO-64
> URL: https://issues.apache.org/jira/browse/PIO-64
> Project: PredictionIO
> Issue Type: Bug
> Affects Versions: 0.11.0-incubating
> Environment: Travis CI
> Reporter: Donald Szeto
> Labels: newbie
>
> The creation timestamp of a test event mismatch the expectation by 1
> millisecond and sometimes causes annoyance with PR's tests not passing even
> though the error is irrelevant.
> Example test failure:
> https://travis-ci.org/apache/incubator-predictionio/jobs/228316305
> Excerpt of output above:
> {code}
> [info] PEventsSpec
> [info]
> [info] PredictionIO Storage PEvents Specification
> [info]
> [info] PEvents can be implemented by:
> [info] - JDBCPEvents
> [info]
> [info] JDBCPEvents should
> [info] - behave like any PEvents implementation
> [info]
> [info] + - (init test)
> [info] + - (insert test events)
> [info] + find in default
> [info] + find in channel
> [info] + aggregate user properties in default
> [info] + aggregate user properties in channel
> [info] + write to default
> [info] x write to channel
> [error]
> List(Event(id=None,event=$set,eType=user,eId=u3,tType=None,tId=None,p=DataMap(Map(a
> -> JInt(22), b -> JString(value13), d -> JArray(List(JInt(5), JInt(6),
> JInt(1))))),t=1970-01-01T01:49:03.410Z,tags=List(),pKey=None,ct=2017-05-03T12:43:42.170Z),
>
> Event(id=None,event=$unset,eType=user,eId=u3,tType=None,tId=None,p=DataMap(Map(a
> ->
> JNull)),t=1970-01-02T01:49:03.410Z,tags=List(),pKey=None,ct=2017-05-03T12:43:42.170Z),
>
> Event(id=None,event=$set,eType=user,eId=u3,tType=None,tId=None,p=DataMap(Map(b
> -> JString(value10), f -> JString(new12), d -> JArray(List(JInt(1), JInt(3),
> JInt(2))))),t=1970-01-03T01:49:03.410Z,tags=List(),pKey=None,ct=2017-05-03T12:43:42.170Z),
>
> Event(id=None,event=my_event3,eType=my_entity_type,eId=my_entity_id,tType=Some(my_target_entity_type),tId=Some(my_target_entity_id),p=DataMap(Map(propA
> -> JDouble(1.2345), propB ->
> JString(valueB))),t=2017-05-03T12:43:42.172Z,tags=List(),pKey=Some(my_prid),ct=2017-05-03T12:43:42.172Z),
>
> Event(id=None,event=my_event4,eType=my_entity_type4,eId=my_entity_id4,tType=Some(my_target_entity_type4),tId=Some(my_target_entity_id4),p=DataMap(Map(prop6
> -> JDouble(4.56), prop1 -> JInt(1), prop5 -> JArray(List(JString(a),
> JString(b), JString(c))), prop2 -> JString(value2), prop4 -> JBool(true),
> prop3 -> JArray(List(JInt(1), JInt(2),
> JInt(3))))),t=2017-05-03T12:43:42.172Z,tags=List(),pKey=None,ct=2017-05-03T12:43:42.172Z),
>
> Event(id=None,event=my_event6,eType=my_entity_type6,eId=my_entity_id6,tType=Some(my_target_entity_type6),tId=Some(my_target_entity_id6),p=DataMap(Map(prop6
> -> JDouble(4.56), prop1 -> JInt(6), prop5 -> JArray(List(JString(a),
> JString(b), JString(c))), prop2 -> JString(value2), prop4 -> JBool(true),
> prop3 -> JArray(List(JInt(6), JInt(7),
> JInt(8))))),t=2017-05-03T12:43:42.172Z,tags=List(),pKey=None,ct=2017-05-03T12:43:42.172Z),
>
> Event(id=None,event=my_event,eType=my_entity_type,eId=my_entity_id,tType=Some(my_target_entity_type),tId=Some(my_target_entity_id),p=DataMap(Map(prop6
> -> JDouble(4.56), prop1 -> JInt(1), prop5 -> JArray(List(JString(a),
> JString(b), JString(c))), prop2 -> JString(value2), prop4 -> JBool(true),
> prop3 -> JArray(List(JInt(1), JInt(2),
> JInt(3))))),t=2017-05-03T12:43:42.171Z,tags=List(),pKey=Some(my_prid),ct=2017-05-03T12:43:42.171Z),
>
> Event(id=None,event=my_event5,eType=my_entity_type5,eId=my_entity_id5,tType=Some(my_target_entity_type5),tId=Some(my_target_entity_id5),p=DataMap(Map(prop6
> -> JDouble(4.56), prop1 -> JInt(1), prop5 -> JArray(List(JString(a),
> JString(b), JString(c))), prop2 -> JString(value2), prop4 -> JBool(true),
> prop3 -> JArray(List(JInt(1), JInt(2),
> JInt(3))))),t=2017-05-03T12:43:42.172Z,tags=List(),pKey=None,ct=2017-05-03T12:43:42.172Z))
> [error] is missing:
> Event(id=None,event=my_event,eType=my_entity_type,eId=my_entity_id,tType=Some(my_target_entity_type),tId=Some(my_target_entity_id),p=DataMap(Map(prop6
> -> JDouble(4.56), prop1 -> JInt(1), prop5 -> JArray(List(JString(a),
> JString(b), JString(c))), prop2 -> JString(value2), prop4 -> JBool(true),
> prop3 -> JArray(List(JInt(1), JInt(2),
> JInt(3))))),t=2017-05-03T12:43:42.171Z,tags=List(),pKey=Some(my_prid),ct=2017-05-03T12:43:42.172Z)
> [error] must not contain:
> Event(id=None,event=my_event,eType=my_entity_type,eId=my_entity_id,tType=Some(my_target_entity_type),tId=Some(my_target_entity_id),p=DataMap(Map(prop6
> -> JDouble(4.56), prop1 -> JInt(1), prop5 -> JArray(List(JString(a),
> JString(b), JString(c))), prop2 -> JString(value2), prop4 -> JBool(true),
> prop3 -> JArray(List(JInt(1), JInt(2),
> JInt(3))))),t=2017-05-03T12:43:42.171Z,tags=List(),pKey=Some(my_prid),ct=2017-05-03T12:43:42.171Z)
> (PEventsSpec.scala:190)
> [info]
> [info]
> [info]
> [info] - (table cleanup)
> [info] - (table cleanup)
> [info]
> [info]
> [info] - (stop Spark)
> [info]
> [info]
> [info] Total for specification PEventsSpec
> [info] Finished in 3 seconds, 876 ms
> [info] 8 examples, 1 failure, 0 error
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
