[
https://issues.apache.org/jira/browse/PIO-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006248#comment-16006248
]
ASF GitHub Bot commented on PIO-64:
-----------------------------------
GitHub user shimamoto opened a pull request:
https://github.com/apache/incubator-predictionio/pull/382
[PIO-64] Fixed a bug that JDBCPEvents unit tests fail intermittently
Revert the following commit which is the cause of the error:
https://github.com/apache/incubator-predictionio/commit/be3611d9d00625975f1f64de4cc6c1c829d8f542
For more information, see
[here](https://issues.apache.org/jira/browse/PIO-64?focusedCommentId=16004227&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16004227).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shimamoto/incubator-predictionio
pio-64_unit-tests-fail
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-predictionio/pull/382.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #382
----
commit b623fb0b8c4bf6113c99564bd4d0d675f1526e05
Author: shimamoto <[email protected]>
Date: 2017-05-10T11:14:47Z
[PIO-64] Fixed a bug that JDBCPEvents unit tests fail intermittently.
Revert the following commit which is the cause of the error:
https://github.com/apache/incubator-predictionio/commit/be3611d9d00625975f1f64de4cc6c1c829d8f542
----
> JDBCPEvents unit tests fail intermittently
> ------------------------------------------
>
> Key: PIO-64
> URL: https://issues.apache.org/jira/browse/PIO-64
> Project: PredictionIO
> Issue Type: Bug
> Affects Versions: 0.11.0-incubating
> Environment: Travis CI
> Reporter: Donald Szeto
> Labels: newbie
>
> The creation timestamp of a test event mismatch the expectation by 1
> millisecond and sometimes causes annoyance with PR's tests not passing even
> though the error is irrelevant.
> Example test failure:
> https://travis-ci.org/apache/incubator-predictionio/jobs/228316305
> Excerpt of output above:
> {code}
> [info] PEventsSpec
> [info]
> [info] PredictionIO Storage PEvents Specification
> [info]
> [info] PEvents can be implemented by:
> [info] - JDBCPEvents
> [info]
> [info] JDBCPEvents should
> [info] - behave like any PEvents implementation
> [info]
> [info] + - (init test)
> [info] + - (insert test events)
> [info] + find in default
> [info] + find in channel
> [info] + aggregate user properties in default
> [info] + aggregate user properties in channel
> [info] + write to default
> [info] x write to channel
> [error]
> List(Event(id=None,event=$set,eType=user,eId=u3,tType=None,tId=None,p=DataMap(Map(a
> -> JInt(22), b -> JString(value13), d -> JArray(List(JInt(5), JInt(6),
> JInt(1))))),t=1970-01-01T01:49:03.410Z,tags=List(),pKey=None,ct=2017-05-03T12:43:42.170Z),
>
> Event(id=None,event=$unset,eType=user,eId=u3,tType=None,tId=None,p=DataMap(Map(a
> ->
> JNull)),t=1970-01-02T01:49:03.410Z,tags=List(),pKey=None,ct=2017-05-03T12:43:42.170Z),
>
> Event(id=None,event=$set,eType=user,eId=u3,tType=None,tId=None,p=DataMap(Map(b
> -> JString(value10), f -> JString(new12), d -> JArray(List(JInt(1), JInt(3),
> JInt(2))))),t=1970-01-03T01:49:03.410Z,tags=List(),pKey=None,ct=2017-05-03T12:43:42.170Z),
>
> Event(id=None,event=my_event3,eType=my_entity_type,eId=my_entity_id,tType=Some(my_target_entity_type),tId=Some(my_target_entity_id),p=DataMap(Map(propA
> -> JDouble(1.2345), propB ->
> JString(valueB))),t=2017-05-03T12:43:42.172Z,tags=List(),pKey=Some(my_prid),ct=2017-05-03T12:43:42.172Z),
>
> Event(id=None,event=my_event4,eType=my_entity_type4,eId=my_entity_id4,tType=Some(my_target_entity_type4),tId=Some(my_target_entity_id4),p=DataMap(Map(prop6
> -> JDouble(4.56), prop1 -> JInt(1), prop5 -> JArray(List(JString(a),
> JString(b), JString(c))), prop2 -> JString(value2), prop4 -> JBool(true),
> prop3 -> JArray(List(JInt(1), JInt(2),
> JInt(3))))),t=2017-05-03T12:43:42.172Z,tags=List(),pKey=None,ct=2017-05-03T12:43:42.172Z),
>
> Event(id=None,event=my_event6,eType=my_entity_type6,eId=my_entity_id6,tType=Some(my_target_entity_type6),tId=Some(my_target_entity_id6),p=DataMap(Map(prop6
> -> JDouble(4.56), prop1 -> JInt(6), prop5 -> JArray(List(JString(a),
> JString(b), JString(c))), prop2 -> JString(value2), prop4 -> JBool(true),
> prop3 -> JArray(List(JInt(6), JInt(7),
> JInt(8))))),t=2017-05-03T12:43:42.172Z,tags=List(),pKey=None,ct=2017-05-03T12:43:42.172Z),
>
> Event(id=None,event=my_event,eType=my_entity_type,eId=my_entity_id,tType=Some(my_target_entity_type),tId=Some(my_target_entity_id),p=DataMap(Map(prop6
> -> JDouble(4.56), prop1 -> JInt(1), prop5 -> JArray(List(JString(a),
> JString(b), JString(c))), prop2 -> JString(value2), prop4 -> JBool(true),
> prop3 -> JArray(List(JInt(1), JInt(2),
> JInt(3))))),t=2017-05-03T12:43:42.171Z,tags=List(),pKey=Some(my_prid),ct=2017-05-03T12:43:42.171Z),
>
> Event(id=None,event=my_event5,eType=my_entity_type5,eId=my_entity_id5,tType=Some(my_target_entity_type5),tId=Some(my_target_entity_id5),p=DataMap(Map(prop6
> -> JDouble(4.56), prop1 -> JInt(1), prop5 -> JArray(List(JString(a),
> JString(b), JString(c))), prop2 -> JString(value2), prop4 -> JBool(true),
> prop3 -> JArray(List(JInt(1), JInt(2),
> JInt(3))))),t=2017-05-03T12:43:42.172Z,tags=List(),pKey=None,ct=2017-05-03T12:43:42.172Z))
> [error] is missing:
> Event(id=None,event=my_event,eType=my_entity_type,eId=my_entity_id,tType=Some(my_target_entity_type),tId=Some(my_target_entity_id),p=DataMap(Map(prop6
> -> JDouble(4.56), prop1 -> JInt(1), prop5 -> JArray(List(JString(a),
> JString(b), JString(c))), prop2 -> JString(value2), prop4 -> JBool(true),
> prop3 -> JArray(List(JInt(1), JInt(2),
> JInt(3))))),t=2017-05-03T12:43:42.171Z,tags=List(),pKey=Some(my_prid),ct=2017-05-03T12:43:42.172Z)
> [error] must not contain:
> Event(id=None,event=my_event,eType=my_entity_type,eId=my_entity_id,tType=Some(my_target_entity_type),tId=Some(my_target_entity_id),p=DataMap(Map(prop6
> -> JDouble(4.56), prop1 -> JInt(1), prop5 -> JArray(List(JString(a),
> JString(b), JString(c))), prop2 -> JString(value2), prop4 -> JBool(true),
> prop3 -> JArray(List(JInt(1), JInt(2),
> JInt(3))))),t=2017-05-03T12:43:42.171Z,tags=List(),pKey=Some(my_prid),ct=2017-05-03T12:43:42.171Z)
> (PEventsSpec.scala:190)
> [info]
> [info]
> [info]
> [info] - (table cleanup)
> [info] - (table cleanup)
> [info]
> [info]
> [info] - (stop Spark)
> [info]
> [info]
> [info] Total for specification PEventsSpec
> [info] Finished in 3 seconds, 876 ms
> [info] 8 examples, 1 failure, 0 error
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
