Samunroyu commented on code in PR #2328:
URL:
https://github.com/apache/incubator-pegasus/pull/2328#discussion_r2925619755
##########
src/rpc/rpc_host_port.h:
##########
Review Comment:
`_obj.__isset.hp_##field = false;` will cause
`CHECK(pc.hp_last_drops.empty(), "last_drops of partition({}) must be empty",
pid);` failed.
i think keep hp_xxx empty in the partition_configuration that is acceptable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
