Samunroyu commented on code in PR #2328:
URL:
https://github.com/apache/incubator-pegasus/pull/2328#discussion_r2909768582
##########
src/rpc/rpc_host_port.h:
##########
@@ -215,15 +215,18 @@ class TProtocol;
// Head insert 'hp' and its DNS resolved rpc_address to the optional vector
'hp_<field>' and vector
// '<field>' of 'obj'. The types of the fields are std::vector<rpc_address> and
// std::vector<host_port>, respectively.
-#define HEAD_INSERT_IP_AND_HOST_PORT_BY_DNS(obj, field, hp)
\
+#define HEAD_INSERT_IP_AND_HOST_PORT_BY_DNS(obj, field, hp, target)
\
Review Comment:
i think it's quite clear. The macro will cause test failures without those
change.
`HEAD_INSERT_IP_AND_HOST_PORT_BY_DNS` should be same as `GET_HOSTS_PORT`
that us temporary variable to process fqdn.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
