On 11/06/2015 03:34 PM, Andrea Pescetti wrote:
> Kay Schenk wrote:
>> On 11/05/2015 04:12 PM, Kay Schenk wrote:
>>> I just committed my few changes that I made to the devtools area.
>> As we have delayed these update feeds more than normal, unless there
>> is an objection, I will plan on committing them on Sunday, PST in
>> the am sometime.
>
> 1) 4.1.1 to 4.1.2
>
> I tried running the scripts and indeed everything works as expected.
> They even found a typo: I compared the output of
> $ ./generate-update-feed.sh 4.1.1 4.1.2
> to the current feed at
> http://svn.apache.org/viewvc/openoffice/updates-site/trunk/aoo411/check.Update?view=co&content-type=text%2Fplain
>
>
> and it found that line 1870 (and 3 more ones) has a typo:
>
> <inst:update type="text/html"
> src="http://www.openoffice.org/pt/download?utm_source=AOO4_1_1_lt&utm_medium=Client&utm_campaign=Upgrade"/>
>
>
> The utm_source should be "AOO4_1_1_pt" not "AOO4_1_1_lt".
>
> The script-generated version fixes it.
>
> 2) 4.x.y to 4.1.2
>
> I compared, in pairs, the current attachments to
> https://bz.apache.org/ooo/show_bug.cgi?id=126612
> and I confirm that in all 3 cases the script-generated version has
> the correct links, and fixes small issues with the manually
> generated (with old data) version.
>
> 3) One remaining issue
>
> On line 4 of the generated feeds, the "updated" date is invalid.
>
> Manually entered value:
> <updated>Wed, Oct 28, 2015 19:56:54 UTC</updated>
>
> Script-generated value (on your system):
> <updated>Thu Nov 5 21:35:43 UTC 2015 UTC</updated>
>
> This should be fixed manually (by copying the "manual" value to it),
> or line 187 of the script at
> http://svn.apache.org/viewvc/openoffice/devtools/genUpdateFeed/generate-update-feed.sh?diff_format=h&view=markup
>
> should get the correct parameters for date.
>
> Regards,
> Andrea.
Ok. Yeah, I remarked about the date in the attachments, so I will
change to Oct 28. I will recommit 4.1.1 to 4.1.2 using the script
version.
I don't plan on reattaching the corrections to the issue. I will
just do these fixes and commit on Sunday.
--
--------------------------------------------
MzK
“The journey of a thousand miles begins
with a single step.”
--Lao Tzu
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
