Looks like my local tags might be out of sync with the remote. If I can't resolve it i'll roll everything back once more and clone the repo freshly and try again.
On Mon, Jun 8, 2020 at 7:23 PM Paul Nicolucci <[email protected]> wrote: > Already, I've given this another shot this evening and seems something > still isn't cleaned up correctly from my previous attempt. I get the > following: > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-release-plugin:2.5.3:prepare (default-cli) > on project myfaces-core-module: Unable to tag SCM > [ERROR] Provider message: > [ERROR] The git-tag command failed. > [ERROR] Command output: > [ERROR] fatal: tag 'myfaces-core-module-2.2.13' already exists > [ERROR] -> [Help 1] > [ERROR] > [ERROR] To see the full stack trace of the errors, re-run Maven with the > -e switch. > [ERROR] Re-run Maven using the -X switch to enable full debug logging. > [ERROR] > [ERROR] For more information about the errors and possible solutions, > please read the following articles: > [ERROR] [Help 1] > http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException > [ERROR] > [ERROR] After correcting the problems, you can resume the build with the > command > [ERROR] mvn <goals> -rf :myfaces-core-module > > I don't see where this tag exists, I had manually deleted it: > https://github.com/apache/myfaces/releases/tag/myfaces-core-module-2.2.13 > > Any thoughts on what's going on here or where to look for the tag? > > Thanks, > > Paul Nicolucci > > On Sat, May 9, 2020 at 4:00 AM Thomas Andraschko < > [email protected]> wrote: > >> +1 thanks >> >> Paul Nicolucci <[email protected]> schrieb am Fr., 8. Mai 2020, 22:30: >> >>> I've been messing with this plugin a bit today. I believe I finally have >>> it ignoring the isSurrogate calls now, so we don't need to add an >>> additional optional step to our release now. Thomas, you made the change to >>> ensure we only make those calls in levels of Java where it is available so >>> now we can ignore it as a safe call and move on. >>> >>> I'll push up a commit soon with the changes and then get back to the >>> release. >>> >>> Thanks! >>> >>> On Wed, Apr 29, 2020 at 11:06 AM Thomas Andraschko < >>> [email protected]> wrote: >>> >>>> I thought that you manually added -PcheckJDK into the mvn cmd? >>>> If yes: IMO we can just call it an "optional step" which needs to be >>>> checked; In this case now it fails but we know that that >>>> IllegalXmlCharacterFilterWriter is working fine on java1.6 >>>> >>>> Am Mi., 29. Apr. 2020 um 16:46 Uhr schrieb Paul Nicolucci < >>>> [email protected]>: >>>> >>>>> What do you mean by: "ignore the IllegalXmlCharacterFilterWriter from >>>>> the checkJDK result "manually", the checkJDK is a optional thing in the >>>>> build process. right? we already removed it in 2.3 and later" >>>>> >>>>> Is there something we need to add in the poms or should we just use : >>>>> @IgnoreJRERequirement? >>>>> >>>>> >>>>> >>>>> On Wed, Apr 29, 2020 at 9:51 AM Thomas Andraschko < >>>>> [email protected]> wrote: >>>>> >>>>>> Commited it, please review >>>>>> >>>>>> Am Mi., 29. Apr. 2020 um 15:28 Uhr schrieb Thomas Andraschko < >>>>>> [email protected]>: >>>>>> >>>>>>> I tried to configure the animal-sniffer to exclude the class and >>>>>>> also tried another plugin. I didnt find a way to exclude it. >>>>>>> >>>>>>> I would do the following: >>>>>>> - IllegalXmlCharacterFilterWriter wont be registered for java 1.6, i >>>>>>> will add it this now >>>>>>> - ignore the IllegalXmlCharacterFilterWriter from the checkJDK >>>>>>> result "manually", the checkJDK is a optional thing in the build >>>>>>> process. >>>>>>> right? we already removed it in 2.3 and later >>>>>>> >>>>>>> WDYT? >>>>>>> >>>>>>> Am Mi., 29. Apr. 2020 um 14:55 Uhr schrieb Thomas Andraschko < >>>>>>> [email protected]>: >>>>>>> >>>>>>>> Puh, no idea but i would just delete it >>>>>>>> >>>>>>>> Am Mi., 29. Apr. 2020 um 14:53 Uhr schrieb Paul Nicolucci < >>>>>>>> [email protected]>: >>>>>>>> >>>>>>>>> Yea I think that would work! >>>>>>>>> >>>>>>>>> Looks like I'll need to manually delete the 2.2.13 tag? Doesn't >>>>>>>>> look like the release plugin rollback actually did that. The rollback >>>>>>>>> did >>>>>>>>> revert the commits that were made so that was at least helpful. I >>>>>>>>> dropped >>>>>>>>> the repo in nexus as well. >>>>>>>>> >>>>>>>>> >>>>>>>>> https://github.com/apache/myfaces/releases/tag/myfaces-core-module-2.2.13 >>>>>>>>> >>>>>>>>> Any objection? >>>>>>>>> >>>>>>>>> On Wed, Apr 29, 2020 at 8:44 AM Thomas Andraschko < >>>>>>>>> [email protected]> wrote: >>>>>>>>> >>>>>>>>>> Oh, stop >>>>>>>>>> this would not fix the build, just runtime :D >>>>>>>>>> maybe we cann exclude this file + add the IF-statement? >>>>>>>>>> >>>>>>>>>> Am Mi., 29. Apr. 2020 um 14:43 Uhr schrieb Thomas Andraschko < >>>>>>>>>> [email protected]>: >>>>>>>>>> >>>>>>>>>>> I think we can also do something like: >>>>>>>>>>> if (java16) { registerIllegalXmlCharacterFilterWriter } >>>>>>>>>>> >>>>>>>>>>> i can easily add this >>>>>>>>>>> >>>>>>>>>>> Am Mi., 29. Apr. 2020 um 14:33 Uhr schrieb Paul Nicolucci < >>>>>>>>>>> [email protected]>: >>>>>>>>>>> >>>>>>>>>>>> In my opinion removing the security feature doesn't seem like >>>>>>>>>>>> a good option although I'm not quite sure which part of this is >>>>>>>>>>>> related to >>>>>>>>>>>> security. >>>>>>>>>>>> >>>>>>>>>>>> Removing support for JRE 1.6 or rewriting the solution seem >>>>>>>>>>>> like better options to me. >>>>>>>>>>>> >>>>>>>>>>>> While we decide as a community how to move forward I'll work >>>>>>>>>>>> today to roll back the current release work for 2.2.13 and we can >>>>>>>>>>>> try again >>>>>>>>>>>> once we have a resolution to this problem. So far I don't see >>>>>>>>>>>> anything else >>>>>>>>>>>> holding up the release so it should go pretty smoothly once we >>>>>>>>>>>> have a >>>>>>>>>>>> solution. >>>>>>>>>>>> >>>>>>>>>>>> Thanks, >>>>>>>>>>>> >>>>>>>>>>>> Paul Nicolucci >>>>>>>>>>>> >>>>>>>>>>>> On Wed, Apr 29, 2020 at 3:06 AM Thomas Andraschko < >>>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> Hi Paul, >>>>>>>>>>>>> >>>>>>>>>>>>> no idea about the TCK. I think it's ok to release without it >>>>>>>>>>>>> for now. Maybe we should check it again for a 3.0 Jakarta Release. >>>>>>>>>>>>> >>>>>>>>>>>>> About the Surrogate.... I think that method was introduced in >>>>>>>>>>>>> JRE 1.7. >>>>>>>>>>>>> What should we do here? We have the following options: >>>>>>>>>>>>> - mark 2.2.13 to not support JRE 1.6 anymore >>>>>>>>>>>>> - rewrite the logic to >>>>>>>>>>>>> *isSurrogatePair* >>>>>>>>>>>>> >>>>>>>>>>>>> *- remove the new security feature from 2.2* >>>>>>>>>>>>> >>>>>>>>>>>>> Best regards, >>>>>>>>>>>>> Thomas >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail> >>>>>>>>>>>>> Virenfrei. >>>>>>>>>>>>> www.avast.com >>>>>>>>>>>>> <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail> >>>>>>>>>>>>> <#m_2838997898411235626_m_-969563006101354261_m_5556505266042472403_m_-1771847198183879653_m_-7678851090439836353_m_2814367587783863413_m_3767760207116600608_m_2565556580547432706_m_4748936653003788754_m_-5071755378333029422_m_-3887418295666435641_m_-609684724139548675_m_4062766699865055724_DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2> >>>>>>>>>>>>> >>>>>>>>>>>>> Am Mi., 29. Apr. 2020 um 01:49 Uhr schrieb Paul Nicolucci < >>>>>>>>>>>>> [email protected]>: >>>>>>>>>>>>> >>>>>>>>>>>>>> A second issue I just ran into during the final part of the >>>>>>>>>>>>>> release: >>>>>>>>>>>>>> >>>>>>>>>>>>>> mvn release:perform -DperformRelease=true >>>>>>>>>>>>>> >>>>>>>>>>>>>> Is the following error: >>>>>>>>>>>>>> >>>>>>>>>>>>>> INFO] [INFO] --- animal-sniffer:1.2:check (default) @ >>>>>>>>>>>>>> myfaces-impl --- >>>>>>>>>>>>>> [INFO] [INFO] Checking unresolved references to >>>>>>>>>>>>>> org.jvnet.animal-sniffer:java1.6:1.0 >>>>>>>>>>>>>> [INFO] [ERROR] Undefined reference: >>>>>>>>>>>>>> java/lang/Character.isSurrogate(C)Z in >>>>>>>>>>>>>> /root/myfaces/myfacesGit22/myfaces/target/checkout/impl/target/classes/org/apache/myfaces/util/IllegalXmlCharacterFilterWriter.class >>>>>>>>>>>>>> >>>>>>>>>>>>>> This looks to be due to: >>>>>>>>>>>>>> https://github.com/apache/myfaces/commit/946b8c9819c22c29a4dc21f77cc0f53e63838e54#diff-5d59811aabbe2aca58ad6f7f4e678485 >>>>>>>>>>>>>> >>>>>>>>>>>>>> The build suggests the following: [INFO] [ERROR] Failed to >>>>>>>>>>>>>> execute goal org.jvnet:animal-sniffer:1.2:check (default) on >>>>>>>>>>>>>> project >>>>>>>>>>>>>> myfaces-impl: Signature errors found. Verify them and put >>>>>>>>>>>>>> @IgnoreJRERequirement on them. -> [Help 1] >>>>>>>>>>>>>> >>>>>>>>>>>>>> However I'm not familiar with this plugin so wanted to get >>>>>>>>>>>>>> another set of eyes as to what the best route to take here is. >>>>>>>>>>>>>> >>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>> >>>>>>>>>>>>>> Paul Nicolucci >>>>>>>>>>>>>> >>>>>>>>>>>>>> On Tue, Apr 28, 2020 at 7:33 PM Paul Nicolucci < >>>>>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>>> I started the 2.2.13 release tonight and one thing I noticed >>>>>>>>>>>>>>> in some of the 2.2. notes is that there looks to have been a >>>>>>>>>>>>>>> TCK run for >>>>>>>>>>>>>>> 2.2.12: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> https://cwiki.apache.org/confluence/display/MYFACES2/CoreRelease2212 >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> For 2.3 our docs says there is no TCK for 2.3: >>>>>>>>>>>>>>> https://myfaces.apache.org/core23/release-checklist.html >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> 1) Does anyone know if we still need to do this for the 2.2. >>>>>>>>>>>>>>> release? >>>>>>>>>>>>>>> 2) If we do need to do a TCK run then does anyone have >>>>>>>>>>>>>>> instructions? >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Paul Nicolucci >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> On Sun, Apr 19, 2020 at 7:18 AM Paul Nicolucci < >>>>>>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Hey Thomas, >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Yes, I'll work to get some time available for this in the >>>>>>>>>>>>>>>> next couple weeks. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Sorry for the delay. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Regards, >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Paul Nicolucci >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> On Sun, Apr 19, 2020, 6:49 AM Thomas Andraschko < >>>>>>>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Hi Paul, >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> would you like to get back to the 2.2.13 release? :) >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail> >>>>>>>>>>>>>>>>> Virenfrei. >>>>>>>>>>>>>>>>> www.avast.com >>>>>>>>>>>>>>>>> <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail> >>>>>>>>>>>>>>>>> <#m_2838997898411235626_m_-969563006101354261_m_5556505266042472403_m_-1771847198183879653_m_-7678851090439836353_m_2814367587783863413_m_3767760207116600608_m_2565556580547432706_m_4748936653003788754_m_-5071755378333029422_m_-3887418295666435641_m_-609684724139548675_m_4062766699865055724_m_7435407121833504545_m_-3745534175071714070_m_-1055247738733888678_m_-1092976417186523802_DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Am Do., 14. Nov. 2019 um 14:58 Uhr schrieb Bill Lucy < >>>>>>>>>>>>>>>>> [email protected]>: >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> +1 sounds good to me, thanks Paul. >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> On Wed, Nov 13, 2019 at 12:44 PM Thomas Andraschko < >>>>>>>>>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> +1 >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> Am Mi., 13. Nov. 2019 um 18:33 Uhr schrieb Paul >>>>>>>>>>>>>>>>>>> Nicolucci <[email protected]>: >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> Hi, >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> Just to keep everyone informed we had an issue in 2.3.5 >>>>>>>>>>>>>>>>>>>> [1] that we have fixed and have targeted for 2.3.6. I'd >>>>>>>>>>>>>>>>>>>> like to start a >>>>>>>>>>>>>>>>>>>> 2.3.6 release to get that fix out and then I'll get back >>>>>>>>>>>>>>>>>>>> to the 2.2.13 >>>>>>>>>>>>>>>>>>>> release. >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> Any questions or objections let me know. >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> Paul Nicolucci >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> [1]: https://issues.apache.org/jira/browse/MYFACES-4309 >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>
