Yea I think that would work! Looks like I'll need to manually delete the 2.2.13 tag? Doesn't look like the release plugin rollback actually did that. The rollback did revert the commits that were made so that was at least helpful. I dropped the repo in nexus as well.
https://github.com/apache/myfaces/releases/tag/myfaces-core-module-2.2.13 Any objection? On Wed, Apr 29, 2020 at 8:44 AM Thomas Andraschko < [email protected]> wrote: > Oh, stop > this would not fix the build, just runtime :D > maybe we cann exclude this file + add the IF-statement? > > Am Mi., 29. Apr. 2020 um 14:43 Uhr schrieb Thomas Andraschko < > [email protected]>: > >> I think we can also do something like: >> if (java16) { registerIllegalXmlCharacterFilterWriter } >> >> i can easily add this >> >> Am Mi., 29. Apr. 2020 um 14:33 Uhr schrieb Paul Nicolucci < >> [email protected]>: >> >>> In my opinion removing the security feature doesn't seem like a good >>> option although I'm not quite sure which part of this is related to >>> security. >>> >>> Removing support for JRE 1.6 or rewriting the solution seem like better >>> options to me. >>> >>> While we decide as a community how to move forward I'll work today to >>> roll back the current release work for 2.2.13 and we can try again once we >>> have a resolution to this problem. So far I don't see anything else holding >>> up the release so it should go pretty smoothly once we have a solution. >>> >>> Thanks, >>> >>> Paul Nicolucci >>> >>> On Wed, Apr 29, 2020 at 3:06 AM Thomas Andraschko < >>> [email protected]> wrote: >>> >>>> Hi Paul, >>>> >>>> no idea about the TCK. I think it's ok to release without it for now. >>>> Maybe we should check it again for a 3.0 Jakarta Release. >>>> >>>> About the Surrogate.... I think that method was introduced in JRE 1.7. >>>> What should we do here? We have the following options: >>>> - mark 2.2.13 to not support JRE 1.6 anymore >>>> - rewrite the logic to >>>> *isSurrogatePair* >>>> >>>> *- remove the new security feature from 2.2* >>>> >>>> Best regards, >>>> Thomas >>>> >>>> >>>> >>>> >>>> >>>> <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail> >>>> Virenfrei. >>>> www.avast.com >>>> <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail> >>>> <#m_-5071755378333029422_m_-3887418295666435641_m_-609684724139548675_m_4062766699865055724_DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2> >>>> >>>> Am Mi., 29. Apr. 2020 um 01:49 Uhr schrieb Paul Nicolucci < >>>> [email protected]>: >>>> >>>>> A second issue I just ran into during the final part of the release: >>>>> >>>>> mvn release:perform -DperformRelease=true >>>>> >>>>> Is the following error: >>>>> >>>>> INFO] [INFO] --- animal-sniffer:1.2:check (default) @ myfaces-impl --- >>>>> [INFO] [INFO] Checking unresolved references to >>>>> org.jvnet.animal-sniffer:java1.6:1.0 >>>>> [INFO] [ERROR] Undefined reference: >>>>> java/lang/Character.isSurrogate(C)Z in >>>>> /root/myfaces/myfacesGit22/myfaces/target/checkout/impl/target/classes/org/apache/myfaces/util/IllegalXmlCharacterFilterWriter.class >>>>> >>>>> This looks to be due to: >>>>> https://github.com/apache/myfaces/commit/946b8c9819c22c29a4dc21f77cc0f53e63838e54#diff-5d59811aabbe2aca58ad6f7f4e678485 >>>>> >>>>> The build suggests the following: [INFO] [ERROR] Failed to execute >>>>> goal org.jvnet:animal-sniffer:1.2:check (default) on project myfaces-impl: >>>>> Signature errors found. Verify them and put @IgnoreJRERequirement on them. >>>>> -> [Help 1] >>>>> >>>>> However I'm not familiar with this plugin so wanted to get another set >>>>> of eyes as to what the best route to take here is. >>>>> >>>>> Thanks, >>>>> >>>>> Paul Nicolucci >>>>> >>>>> On Tue, Apr 28, 2020 at 7:33 PM Paul Nicolucci <[email protected]> >>>>> wrote: >>>>> >>>>>> I started the 2.2.13 release tonight and one thing I noticed in some >>>>>> of the 2.2. notes is that there looks to have been a TCK run for 2.2.12: >>>>>> >>>>>> https://cwiki.apache.org/confluence/display/MYFACES2/CoreRelease2212 >>>>>> >>>>>> For 2.3 our docs says there is no TCK for 2.3: >>>>>> https://myfaces.apache.org/core23/release-checklist.html >>>>>> >>>>>> 1) Does anyone know if we still need to do this for the 2.2. release? >>>>>> 2) If we do need to do a TCK run then does anyone have instructions? >>>>>> >>>>>> Thanks, >>>>>> >>>>>> Paul Nicolucci >>>>>> >>>>>> On Sun, Apr 19, 2020 at 7:18 AM Paul Nicolucci <[email protected]> >>>>>> wrote: >>>>>> >>>>>>> Hey Thomas, >>>>>>> >>>>>>> Yes, I'll work to get some time available for this in the next >>>>>>> couple weeks. >>>>>>> >>>>>>> Sorry for the delay. >>>>>>> >>>>>>> Regards, >>>>>>> >>>>>>> Paul Nicolucci >>>>>>> >>>>>>> On Sun, Apr 19, 2020, 6:49 AM Thomas Andraschko < >>>>>>> [email protected]> wrote: >>>>>>> >>>>>>>> Hi Paul, >>>>>>>> >>>>>>>> would you like to get back to the 2.2.13 release? :) >>>>>>>> >>>>>>>> >>>>>>>> <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail> >>>>>>>> Virenfrei. >>>>>>>> www.avast.com >>>>>>>> <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail> >>>>>>>> <#m_-5071755378333029422_m_-3887418295666435641_m_-609684724139548675_m_4062766699865055724_m_7435407121833504545_m_-3745534175071714070_m_-1055247738733888678_m_-1092976417186523802_DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2> >>>>>>>> >>>>>>>> Am Do., 14. Nov. 2019 um 14:58 Uhr schrieb Bill Lucy < >>>>>>>> [email protected]>: >>>>>>>> >>>>>>>>> +1 sounds good to me, thanks Paul. >>>>>>>>> >>>>>>>>> On Wed, Nov 13, 2019 at 12:44 PM Thomas Andraschko < >>>>>>>>> [email protected]> wrote: >>>>>>>>> >>>>>>>>>> +1 >>>>>>>>>> >>>>>>>>>> Am Mi., 13. Nov. 2019 um 18:33 Uhr schrieb Paul Nicolucci < >>>>>>>>>> [email protected]>: >>>>>>>>>> >>>>>>>>>>> Hi, >>>>>>>>>>> >>>>>>>>>>> Just to keep everyone informed we had an issue in 2.3.5 [1] that >>>>>>>>>>> we have fixed and have targeted for 2.3.6. I'd like to start a 2.3.6 >>>>>>>>>>> release to get that fix out and then I'll get back to the 2.2.13 >>>>>>>>>>> release. >>>>>>>>>>> >>>>>>>>>>> Any questions or objections let me know. >>>>>>>>>>> >>>>>>>>>>> Thanks, >>>>>>>>>>> >>>>>>>>>>> Paul Nicolucci >>>>>>>>>>> >>>>>>>>>>> [1]: https://issues.apache.org/jira/browse/MYFACES-4309 >>>>>>>>>>> >>>>>>>>>>
