Sorry Michael, I'm happy now. If you like you can optimize the imports but this is not a requirement for me.
Regards Bernd On Fri, Mar 18, 2011 at 11:10 PM, Michael Freedman <[email protected]> wrote: > Bummer ... we stepped on each other toes as I was just committing most of > the same. Thanks though for this. Let me know if there are additional > issues you want fixed. > > > On 3/18/2011 2:51 PM, Bernd Bohmann wrote: >> >> Hello Michael, >> >> with my last commit I get: >> >> INFO] >> ------------------------------------------------------------------------ >> [INFO] MyFaces Portlet Bridge ................................ SUCCESS >> [1.969s] >> [INFO] MyFaces Portlet Bridge API ............................ SUCCESS >> [0.086s] >> [INFO] MyFaces Portlet Bridge Implementation ................. SUCCESS >> [0.205s] >> [INFO] MyFaces Portlet Bridge Examples ....................... SUCCESS >> [0.277s] >> [INFO] MyFaces Portlet Bridge Blank Project .................. SUCCESS >> [0.085s] >> [INFO] MyFaces Portlet Bridge CarStore Demo .................. SUCCESS >> [0.179s] >> [INFO] MyFaces Portlet Bridge Facelets Guess Demo ............ SUCCESS >> [0.045s] >> [INFO] MyFaces Portlet Bridge GuessNumber JSP Demo ........... SUCCESS >> [0.060s] >> [INFO] MyFaces Portlet Bridge GuessNumber JSP with Mojarra WriteBehind >> Filter Demo SUCCESS [0.058s] >> [INFO] MyFaces Portlet Bridge GuessNumber JSP with MyFaces WriteBehind >> Filter Demo SUCCESS [0.049s] >> [INFO] MyFaces Portlet Bridge HelloDuke Demo ................. SUCCESS >> [0.098s] >> [INFO] MyFaces Portlet Bridge HelloDuke Coordination Demo .... SUCCESS >> [0.088s] >> [INFO] >> ------------------------------------------------------------------------ >> [INFO] >> ------------------------------------------------------------------------ >> [INFO] BUILD SUCCESSFUL >> [INFO] >> ------------------------------------------------------------------------ >> >> for >> >> mvn org.apache.rat:apache-rat-plugin:check >> >> I also added the missing svn properties to trunk. >> >> For me the trunk is now fine. >> >> Regards >> >> >> Bernd >> >> On Fri, Mar 18, 2011 at 3:29 PM, Bernd Bohmann >> <[email protected]> wrote: >>> >>> Hello Michael, >>> >>> i have added an example rat configuration to the 3.0.x branch. >>> >>> You can invoke the plugin with >>> >>> mvn org.apache.rat:apache-rat-plugin:check >>> >>> mvn rat:check >>> >>> does not work because it calls the codehaus rat plugin. I asume the >>> codehaus plugin is defined somewhere in the master poms. >>> >>> If you like I would also fix some missing svn properties >>> >>> see: >>> >>> http://www.apache.org/dev/version-control.html#https-svn-config >>> >>> Regards >>> >>> Bernd >>> >>> >>> On Fri, Mar 18, 2011 at 12:21 PM, Mark Struberg<[email protected]> >>> wrote: >>>> >>>> yup, sorry for taking so long, but Bernd is right, which means a -1 >>>> >>>> e.g. >>>> api/src/main/java/javax/portlet/faces/annotation/BridgeRequestScopeAttributeAdded.java >>>> >>>> This needs to get fixed before we can ship it. >>>> >>>> you can check this yourself by simply invoking >>>> >>>> >>>> $> mvn rat:check >>>> >>>> There might be single files which could be excluded from the scan, but >>>> overally it works very well. >>>> >>>> LieGrue, >>>> strub >>>> >>>> >>>> --- On Fri, 3/18/11, Bernd Bohmann<[email protected]> wrote: >>>> >>>>> From: Bernd Bohmann<[email protected]> >>>>> Subject: Re: [VOTE] Release MyFaces Portlet Bridge 3.0.0 >>>>> To: "MyFaces Development"<[email protected]> >>>>> Date: Friday, March 18, 2011, 9:33 AM >>>>> Hello Michael, >>>>> >>>>> i performed a checkout of >>>>> >>>>> http://svn.apache.org/repos/asf/myfaces/portlet-bridge/core/tags/3.0.0-alpha/ >>>>> and I found many files without a license header. >>>>> >>>>> Regards >>>>> >>>>> Bernd >>>>> >>>>> On Thu, Mar 17, 2011 at 5:58 PM, Michael Freedman >>>>> <[email protected]> >>>>> wrote: >>>>>> >>>>>> Reminder -- if you are intending to vote please do so >>>>> >>>>> by mid-day Friday >>>>>> >>>>>> (PST) as I want to close the vote before the weekend. >>>>>> -Mike- >>>>>> >>>>>> On 3/16/2011 1:12 PM, Michael Freedman wrote: >>>>>> >>>>>> +1 >>>>>> >>>>>> FYI ... I plan to close the vote on Friday. >>>>> >>>>> Hopefully I will have some more >>>>>> >>>>>> votes to record by then. >>>>>> -Mike- >>>>>> >>>>>> On 3/15/2011 9:30 AM, Michael Freedman wrote: >>>>>> >>>>>> Here is the information you want -- however I don't >>>>> >>>>> really want to hold this >>>>>> >>>>>> release until MyFaces/Trinidad are released -- rather >>>>> >>>>> can't we use this >>>>>> >>>>>> release as pressure to wrap up releases in these other >>>>> >>>>> projects so they >>>>>> >>>>>> follow shortly? >>>>>> >>>>>> Have folks been waiting to vote because of Scott's >>>>> >>>>> e-mail -- if so I would >>>>>> >>>>>> appreciate your vote so I can close/release this. >>>>>> >>>>>> Trinidad JIRA: >>>>>> TRINIDAD-1996 (Status Fixed 1/26/11) I believe >>>>> >>>>> this fix is in Beta-2 but I >>>>>> >>>>>> haven't tried it yet and another member of the team >>>>> >>>>> reports other problems >>>>>> >>>>>> with using beta-2. I need to investigate more.... >>>>>> >>>>>> MyFaces JIRA: >>>>>> >>>>>> MYFACES-3064: Fixed 3/1/11 Fix Version: >>>>> >>>>> 2.0.5-SNAPSHOT >>>>>> >>>>>> MYFACES-3045: Fixed 3/1/11 Fix Version: >>>>> >>>>> 2.0.5-SNAPSHOT >>>>>> >>>>>> MYFACES-3042: Fixed 2/15/11 Fix Version: Unresolved >>>>> >>>>> -- patch available >>>>>> >>>>>> MYFACES-3039: Fixed 2/18/11 Fix Version: >>>>> >>>>> 2.0.5-SNAPSHOT >>>>>> >>>>>> MYFACES-3038: Fixed 2/18/11 Fix Version: 2.0.4 >>>>>> MYFACES-3017: Fixed 2/9/11 Fix Version: 2.0.4 >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> MyFacesJIRA: >>>>>> >>>>>> On 3/10/2011 5:50 AM, Scott O'Bryan wrote: >>>>>> >>>>>> Hey Mike, do we have JIRA tickets for the Trinidad >>>>> >>>>> patches needed? >>>>>> >>>>>> Also, what are the challenges with the MyFaces >>>>> >>>>> core? I, for one, >>>>>> >>>>>> would like to see this fixed ASAP.. >>>>>> >>>>>> On Mar 9, 2011, at 4:53 PM, Michael Freedman >>>>>> <[email protected]> >>>>> >>>>> wrote: >>>>>> >>>>>> Please vote on the proposed release of MyFaces Portlet >>>>> >>>>> Bridge 3.0.0-alpha. >>>>>> >>>>>> This is the alpha version of the Portlet Bridge for >>>>> >>>>> JSF 2.0. It includes >>>>>> >>>>>> all the base function of JSR329 updated to run in a >>>>> >>>>> JSF 2.0 environment. >>>>>> >>>>>> Some, though not all JSF 2.0 features are >>>>> >>>>> expressed/utilized. Most >>>>>> >>>>>> significant is Ajax support and Composite Component >>>>> >>>>> suppport. Note: this >>>>>> >>>>>> version of the bridge will not work with any currently >>>>> >>>>> released versions of >>>>>> >>>>>> MyFaces (try Trunk) and only mostly runs on released >>>>> >>>>> version of Mojarra >>>>>> >>>>>> (patches available). Likewise a patched version >>>>> >>>>> of Trinidad is needed to >>>>>> >>>>>> run the TCK (for those tests that depend on >>>>> >>>>> Trinidad). >>>>>> >>>>>> Distributable components can be inspected in >>>>>> http://people.apache.org/~mfreedman/portlet-bridge/3.0.0-alpha >>>>>> >>>>>> Repository artifacts are at: >>>>>> >>>>>> https://repository.apache.org/content/repositories/orgapachemyfaces-006/ >>>>>> >>>>>> >>>>>> I have verified that the distributable jars run and >>>>> >>>>> pass the updated version >>>>>> >>>>>> of the JSR 329 TCK. In addition I have verified >>>>> >>>>> that the distributable >>>>>> >>>>>> examples run (on apache tomcat/pluto). >>>>>> >>>>>> ------------------------------------------------ >>>>>> [ ] +1 for community members who have reviewed the >>>>> >>>>> bits >>>>>> >>>>>> [ ] +0 >>>>>> [ ] -1 for fatal flaws that should cause these bits >>>>> >>>>> not to be released, >>>>>> >>>>>> and why.............. >>>>>> >>>>>> Thanks, >>>>>> -Mike- >>>>>> >>>> >>>> >>>> >
