[ 
https://issues.apache.org/jira/browse/MYFACES-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12970197#action_12970197
 ] 

Jakob Korherr commented on MYFACES-2945:
----------------------------------------

Hehe. I actually had it this way first, but then - when writing the code in 
FacesConfigurator - it felt kinda weird to get the whole FacesConfigData only 
from the **Merger SPI without even touching the **Provider SPI.

For me it made more sence to get the **Provider first and then to pass it to 
the **Merger, so that you see on FacesConfigurator that there are acutally two 
SPIs involved.

However, I am also ok to do it the other way. WDYT after this little 
explanation? Please tell me your final opinion and I'll commit an appropriate 
version of the proposed patch!

> Make a way to get the FacesConfig from a provider
> -------------------------------------------------
>
>                 Key: MYFACES-2945
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2945
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: SPI
>    Affects Versions: 2.0.2
>            Reporter: Ivan
>            Assignee: Leonardo Uribe
>             Fix For: 2.0.3-SNAPSHOT
>
>         Attachments: MYFACES-2945-2.patch, MYFACES-2945-3.patch, 
> MYFACES-2945-FacesConfigurationMerger.patch
>
>
> Currently, MyFaces startup listener will parse the all the faces 
> configuration files and sort them on each startup time, and it will be better 
> to do it once in the deployment time, and get those data structure instances 
> from a provider. One possible way is to make those FacesConfig class 
> serializable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to