On 25/05/07, Brett Porter <[EMAIL PROTECTED]> wrote:
On 25/05/2007, at 12:57 AM, Mark Hobson wrote:
> Looks like an infinite loop in the first DefaultDownloader.download
> method.
Not sure what you're saying - you've tried it and it doesn't work, or
you just looked at the code and saw a problem?
I looked at the code and was interested in how the local
ArtifactRepository was obtained from a String path, since the first
download method accepts a File and should delegate to the second
download method which accepts an ArtifactRepository. I just noted
that this delegation doesn't actually happen since the File-based
download method simply invokes itself. See:
http://svn.apache.org/repos/asf/maven/shared/trunk/maven-downloader/src/main/java/org/apache/maven/shared/downloader/DefaultDownloader.java
> Right, is there an issue open for this? Could be easier just to fix
> this, although I guess it'd make the release plugin require 2.0.7 -
> would that be acceptable?
No, I don't think plugins should ever depend on an unreleased version
of Maven since they are adopted faster.
Sure, I was envisaging that it could be fixed in 2.0.7 after which the
release plugin could have 2.0.7 as a prerequisite.
I also think that change would be for 2.1 anyway.
Even though it's really a bug fix?
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
