On 29/05/07, Brett Porter <[EMAIL PROTECTED]> wrote:
Heh. Nice catch! Can you get that into JIRA?
Done: http://jira.codehaus.org/browse/MNG-3015
> Sure, I was envisaging that it could be fixed in 2.0.7 after which the > release plugin could have 2.0.7 as a prerequisite. Still an unreleased version :)
I meant: fix in 2.0.7-SNAPSHOT; release 2.0.7; depend on 2.0.7 - but I'm sure you got my drift already ;)
>> I also think that change would be for 2.1 anyway. > > Even though it's really a bug fix? I'm not sure it's going to be a simple fix - it's really going to need a functional enhancement. If you consider the other dependencies as being present, you still need to ensure the goal is running in a phase when the dependencies will actually exist. If install wasn't called, then that won't be the case (or at least package if the packaged artifacts can be used from the target directory).
Yeah, it's probably not going to be easy. I've created a failing IT and raised this issue to keep track of it: http://jira.codehaus.org/browse/MNG-3023 Feel free to sanity check it if you've got time. On 29/05/07, Brett Porter <[EMAIL PROTECTED]> wrote:
I'm not sure I understand why 2.0.6/MNG-1577 is required to simulate @rDR - other plugins already do it on prior versions. However, I'm still not in favour of the release plugin depending on an unreleased version of Maven (even if the root problem can be fixed in 2.0.7).
MNG-1577 introduced an API change with MavenProject.getManagedVersionMap, which is used by the artifact resolving code I'll be simulating in DefaultPluginManager.resolveTransitiveDependencies. Surely MNG-1577 will affect the resolved versions used in the release pom, so we can't use the 2.0 API and expect MNG-1577 style results?
Yes, I see what you mean. I'm not sure putting them into the managed dependencies map will help, as they still won't resolve if they aren't installed. So the sequence might need to be: - resolve the project dependencies, filtering out the reactor projects - add the reactor projects to the list of resolved artifacts - iterate through the reactor projects and resolve each's dependencies (again filtering the reactor projects) and add to the list of resolved artifacts. Does that make sense?
Possibly, I'll consider it properly tomorrow and let you of the next problem ;) Cheers, Mark --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
