My comments are inline. On Tue, Sep 5, 2023 at 1:30 PM Gary Gregory <garydgreg...@gmail.com> wrote:
> Something is wrong with the source zip file at > https://dist.apache.org/repos/dist/dev/logging/logging-parent/: It's a > zip that contains a zip. Why? *The distribution* is a single file containing sources (`src.zip`), binary artifacts[1], and auxiliary support files (release notes, `LICENSE.txt`, `NOTICE.txt`, etc.) I am not able to follow what is wrong with this. [1] In the case of `logging-parent`, there are no binary artifacts. It is just a `pom.xml` and reusable CI workflow YAMLs. > It should be a direct reflection of what > is in the repository IMO. > [By "repository", I assume you mean Nexus.] In the distribution, we provide everything that is available in the repository, plus more. For me the most important detail is the intact sources that one can reproduce the binary artifacts without any changes. Hence, AFAIC, it is a "a direct reflection". Could you give an example of what the distribution misses that is available in the repository? Additionally, Nexus only stores `pom.xml`, though this release of `logging-parent` has a very important addendum: reusable CI workflow YAMLs. And that is what the distribution captures right. Also, the links in the vote email should point to > https://dist.apache.org/repos/dist/dev/logging/logging-parent/ not > https://dist.apache.org/repos/dist/dev/logging such reviewed don't > have to dig through folders. > Check. Will do in the next release.
