I pushed 46f7b08288e1f8843d293bb75950a8b466854ba6 to pull 469.

My recollection is that there was a test failing where I thought the
problem was the test, not the code. The test was checking to see if the log
file was gone inside the @Test and I don't think that is valid. I was
meaning to ask someone if the test was incorrect or if my code was the
problem.

I'll try to get back to this, but I'm slammed with work at the moment.


On Wed, Apr 28, 2021 at 8:42 AM Ralph Goers <ralph.go...@dslextreme.com>
wrote:

> That would be up to you. If you have been working on the same branch there
> shouldn’t be a problem. But if it is going to cause merge conflicts then I
> wouldn’t bother as you can just link to the prior PR for the history.
>
> Ralph
>
> > On Apr 28, 2021, at 7:55 AM, Tim Perry <tim.v...@gmail.com> wrote:
> >
> >
> >
> > It assumes that the status logger is not a singleton. However, status
> logger is a singleton and so this is a problem.
> >
> > I’ve implemented to changes which tracks the different status logger
> listeners by the context name. There are still a couple of kinks to work
> out on that though. If you want, I can push my changes to GitHub and you
> could take a look at those. There is some problem that’s causing some of
> the test to fail and I haven’t had time to figure out what the issue is.
> >
> > Tim
> >
> >
> > Tim Perry
> > (916) 505-3634
>
>

Reply via email to