On Wed, Jan 24, 2018 at 2:33 PM, Ralph Goers <ralph.go...@dslextreme.com> wrote:
> > > > On Jan 24, 2018, at 1:56 PM, Gary Gregory <garydgreg...@gmail.com> > wrote: > > > > On Wed, Jan 24, 2018 at 1:18 PM, Ralph Goers <ralph.go...@dslextreme.com > > > > wrote: > > > >> A vote can’t override a veto of a code commit. > >> > > > > I'm trying to get things to move along toward some kind of workable > > solution we can all live with. Why are you talking about procedure? It > just > > feels obstructionist :-( > > > > You can view it either way. I look at your position of insisting the > stuff stay in the main build as being obstructionist on the one hand and > creating a bloated mess on the other. > > I’ve been complaining about the build for at least a year and finally feel > the issue needs to be forced. Plus, I see us keep adding modules for things > that are not related to what, in my opinion, is the main purpose of the > main repo - to build a Java logging framework that meets the vast majority > of users needs. Other things, like Mongo appenders, are esoteric add-ons > that don’t belong there. Over time I can see this growing to outlandish > proportions as we keep adding things that allow you to integrate with > whatever the latest thing is. To be honest, I am not sure why we don’t have > Appenders that write to Solr, ElasticSearch, or any/every one of the other > things listed at http://nosql-database.org/ <http://nosql-database.org/>. > I have no problem with those integrations but they have no business being > in the main build. I just don’t see how you could possibly believe that > having integrations with all those components in the main build would be a > good thing. > > This discussion does make me wonder how often you perform a full build. I > found it telling that your guidance in the pull request left off running a > full build to detect whether the fix broke anything. As I have said before, > I almost always run a full build before I commit. Based on issues I’ve > found in the past with some of your commits I am pretty sure you don’t do > this, which is why you probably don’t consider this to be as big a problem > as I do. > I usually do not run a full build if I change an appender like MongoDB. Nothing I can change in there should break anything else. Usually. I usually do run a full build if I change something in log4j-core. I do not like to waste my time so I do not even run a build if I change a Javadoc. But sometimes I do, to make sure the Eclipse and Oracle compiler see things the same way. Or, if I make a change in generics since the Eclipse compiler is more lenient than Oracle. Gary > > Ralph > >
