On Mon, Oct 23, 2017 at 12:14 PM, Ralph Goers <ralph.go...@dslextreme.com> wrote:
> So does this mean that log4j-taglib no longer supports servlet 2.5? How > did this happen with no changes? > No idea. Matt mentioned the change did not break anything so I made the change to the POM. I can see [1] that 2.5 is from 2005 (12 years old!) and 3.0 from 2009. Gary [1] https://en.wikipedia.org/wiki/Java_servlet > > Ralph > > > On Oct 23, 2017, at 8:21 AM, Gary Gregory <garydgreg...@gmail.com> > wrote: > > > > On Thu, Oct 19, 2017 at 2:14 PM, Ralph Goers <ralph.go...@dslextreme.com > <mailto:ralph.go...@dslextreme.com>> > > wrote: > > > >> I am wondering why this is suddenly failing. Was it changed recently? > >> > >> Ralph > >> > >>> On Oct 19, 2017, at 1:00 PM, Mikael Ståldal <mi...@apache.org> wrote: > >>> > >>> The missing class, javax.servlet.SessionCookieConfig is new in Servlet > >> API 3.x. In log4j-taglib pom, we have this dependency: > >>> > >>> <dependency> > >>> <groupId>javax.servlet</groupId> > >>> <artifactId>servlet-api</artifactId> > >>> <version>2.5</version> > >>> <scope>provided</scope> > >>> </dependency> > >>> > >>> That's causing the issue, when I changed it to 3.0.1 the test pass. Is > >> there any particular reason for keeping this at version 2.5? > >> > > > > I updated to 3.0.1 with [LOG4J2-2089][TagLib] Update servlet-api provided > > dependency from 2.5 to 3.0.1. > > > > Gary > > > >> > >>> > >>> On 2017-10-19 21:27, Ralph Goers wrote: > >>>> I’m not sure why that would be. AFAIK that hasn’t been modified in a > >> long time. > >>>> Ralph > >>>>> On Oct 19, 2017, at 12:15 PM, Mikael Ståldal <mi...@apache.org> > wrote: > >>>>> > >>>>> I get a bunch of these errors in log4j-taglib when trying to build > >> current master branch locally: > >>>>> > >>>>> [ERROR] Errors: > >>>>> [ERROR] CatchingTagTest.setUp:48 » NoClassDefFound javax/servlet/ > >> SessionCookieConfig > >>>>> [ERROR] CatchingTagTest.setUp:48 » NoClassDefFound javax/servlet/ > >> SessionCookieConfig > >>>>> [ERROR] CatchingTagTest.setUp:48 » NoClassDefFound javax/servlet/ > >> SessionCookieConfig > >>>>> [ERROR] DumpTagTest.setUp:51 » NoClassDefFound javax/servlet/ > >> SessionCookieConfig > >>>>> [ERROR] DumpTagTest.setUp:51 » NoClassDefFound javax/servlet/ > >> SessionCookieConfig > >
