Weird. I have been running so manyv local builds for changes I check in. I must have missed that one! Feel free to revert or investigate unless I get to it first.
Gary On Oct 21, 2017 08:11, "Mikael Ståldal" <mi...@apache.org> wrote: > The problem started here: > https://builds.apache.org/job/Log4j%202.x/3135/ > https://github.com/apache/logging-log4j2/commit/9126644cf85a > 52859690bc8499b0c701a8db3ae7 > > So I guess that the upgrade from Spring Framework 3.x to 4.x by Gary > caused it. > > > On 2017-10-19 22:14, Ralph Goers wrote: > >> I am wondering why this is suddenly failing. Was it changed recently? >> >> Ralph >> >> On Oct 19, 2017, at 1:00 PM, Mikael Ståldal <mi...@apache.org> wrote: >>> >>> The missing class, javax.servlet.SessionCookieConfig is new in Servlet >>> API 3.x. In log4j-taglib pom, we have this dependency: >>> >>> <dependency> >>> <groupId>javax.servlet</groupId> >>> <artifactId>servlet-api</artifactId> >>> <version>2.5</version> >>> <scope>provided</scope> >>> </dependency> >>> >>> That's causing the issue, when I changed it to 3.0.1 the test pass. Is >>> there any particular reason for keeping this at version 2.5? >>> >>> >>> On 2017-10-19 21:27, Ralph Goers wrote: >>> >>>> I’m not sure why that would be. AFAIK that hasn’t been modified in a >>>> long time. >>>> Ralph >>>> >>>>> On Oct 19, 2017, at 12:15 PM, Mikael Ståldal <mi...@apache.org> wrote: >>>>> >>>>> I get a bunch of these errors in log4j-taglib when trying to build >>>>> current master branch locally: >>>>> >>>>> [ERROR] Errors: >>>>> [ERROR] CatchingTagTest.setUp:48 » NoClassDefFound >>>>> javax/servlet/SessionCookieConfig >>>>> [ERROR] CatchingTagTest.setUp:48 » NoClassDefFound >>>>> javax/servlet/SessionCookieConfig >>>>> [ERROR] CatchingTagTest.setUp:48 » NoClassDefFound >>>>> javax/servlet/SessionCookieConfig >>>>> [ERROR] DumpTagTest.setUp:51 » NoClassDefFound >>>>> javax/servlet/SessionCookieConfig >>>>> [ERROR] DumpTagTest.setUp:51 » NoClassDefFound >>>>> javax/servlet/SessionCookieConfig >>>>> >>>>> >>> >>> >> >> >
