I like log4j-samples better than log4j-server for the same reasons that Mikael and Ralph mentioned. True, it has already been released, but the module breakup gives us a chance to clarify our intentions.
(Shameless plug) Every java main() method deserves http://picocli.info > On May 31, 2017, at 4:44, Gary Gregory <garydgreg...@gmail.com> wrote: > >> On Tue, May 30, 2017 at 12:37 PM, Mikael Ståldal <mi...@apache.org> wrote: >> >> Sounds good. I like to declare it as sample, since it is not really >> production ready on the level of quality and security I would like us to >> maintain the core of Log4j. If we want to declare it as production ready, I >> think we have some work to do to improve it. >> >> We recently had to make a security patch for a deserialization >> vulnerability in the code that is now part of log4j-server. And we just got >> a bug report: https://issues.apache.org/jira/browse/LOG4J2-1922 >> >> If we declare it as sample, it would be less urgent to make such patches, >> and to fix such bugs. > > > Except that the code is already released, so that argument is moot :-( > > Gary > > >> >> >>> On 2017-05-30 19:37, Ralph Goers wrote: >>> >>> I plan on moving the log4j-samples module to a separate repo anyway. I >>> see no reason why the server can’t go into that repo. >>> >>>> On May 30, 2017, at 10:33 AM, Matt Sicker <boa...@gmail.com> wrote: >>>> >>>> Making a new repo isn't a big deal. Once we figure out a nice way to >>>> build >>>> two separate repos, that can easily extend to N separate repos, right? ;) >>>> >>>> On 30 May 2017 at 11:26, Mikael Ståldal <mi...@apache.org> wrote: >>>> >>>> I put it in log4j-tools since it Ralph didn't wanted it in the main repo, >>>>> and there was not other existing repo which fitted better. >>>>> >>>>> I don't mind moving it to the main repo, or to some other new repo (if >>>>> we >>>>> find it worth the effort to create and setup yet another repo, I am >>>>> skeptic). I would object reintegrating it into the log4j-core module >>>>> though. >>>>> >>>>> >>>>> >>>>> On 2017-05-29 23:32, Ralph Goers wrote: >>>>> >>>>> I agree it doesn’t belong in the tools repo. It really belongs in a >>>>>> log4j-examples or log4j-samples as that is all it was meant to be. >>>>>> >>>>>> Ralph >>>>>> >>>>>> On May 29, 2017, at 2:06 PM, Gary Gregory <garydgreg...@gmail.com> >>>>>> wrote: >>>>>> >>>>>>> >>>>>>> I find that the Git repo logging-log4j-tools is the wrong home for >>>>>>> log4-server. This is not a tool. It's a runtime component. I do not >>>>>>> see >>>>>>> why >>>>>>> it cannot live in main repo. >>>>>>> >>>>>>> I use tools at development time. YMMV. >>>>>>> >>>>>>> Gary >>>>>>> >>>>>>> -- >>>>>>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org >>>>>>> Java Persistence with Hibernate, Second Edition >>>>>>> <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl? >>>>>>> ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&link >>>>>>> Code=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8> >>>>>>> >>>>>>> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l= >>>>>>> am2&o=1&a=1617290459> >>>>>>> JUnit in Action, Second Edition >>>>>>> <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl? >>>>>>> ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&link >>>>>>> Code=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a >>>>>>> 24de418%22> >>>>>>> >>>>>>> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l= >>>>>>> am2&o=1&a=1935182021> >>>>>>> Spring Batch in Action >>>>>>> <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl? >>>>>>> ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&link >>>>>>> Code=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Bli >>>>>>> nk_id%7D%7D%22%3ESpring+Batch+in+Action> >>>>>>> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l= >>>>>>> am2&o=1&a=1935182951> >>>>>>> Blog: http://garygregory.wordpress.com >>>>>>> Home: http://garygregory.com/ >>>>>>> Tweet! http://twitter.com/GaryGregory >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> >>>>> >>>> >>>> -- >>>> Matt Sicker <boa...@gmail.com> >>>> >>> >>> >>> >> > > > -- > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > Java Persistence with Hibernate, Second Edition > <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8> > > <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459> > JUnit in Action, Second Edition > <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22> > > <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021> > Spring Batch in Action > <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action> > <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951> > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory
