necouchman commented on code in PR #635:
URL: https://github.com/apache/guacamole-server/pull/635#discussion_r3010699842
##########
src/protocols/rdp/rdp.c:
##########
@@ -624,9 +628,8 @@ static int guac_rdp_handle_connection(guac_client* client) {
do {
/* Handle any queued FreeRDP events (this may result in RDP
messages
- * being sent), aborting later if FreeRDP event handling fails */
- if (!guac_rdp_handle_events(rdp_client))
- wait_result = -1;
+ * being sent). */
+ guac_rdp_handle_events(rdp_client);
Review Comment:
Is there a reason we're now ignoring the return value of this function?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
