mike-jumper commented on code in PR #635:
URL: https://github.com/apache/guacamole-server/pull/635#discussion_r3005523766
##########
src/protocols/rdp/rdp.c:
##########
Review Comment:
We should probably remove this dead assignment while we're at it - this
value is definitely either overwritten or ignored in all cases.
##########
src/protocols/rdp/rdp.c:
##########
@@ -623,6 +623,12 @@ static int guac_rdp_handle_connection(guac_client* client)
{
int connection_closing;
do {
+ /* Break if FreeRDP has recorded a connection error */
+ if (freerdp_get_last_error(GUAC_RDP_CONTEXT(rdp_inst)) !=
FREERDP_ERROR_SUCCESS) {
+ wait_result = -1;
+ break;
+ }
Review Comment:
Would this make more sense as part of `rdp_guac_client_wait_for_events()`,
to help satisfy its contract to return "non-zero if an error occurs or the
connection was disconnected and a reconnect is NOT desired"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
