./lineage/src/test/java/org/apache/gravitino/lineage/source/TestLineageOperations.java (OpenLinage, which is Apache license)
Hi, Justin, TestLineageOperations.java doesn't refer to the code from OpenLineage, so we could keep the current Apache license header for TestLineageOperations.java. On Mon, Apr 28, 2025 at 10:14 AM DanHua Wang <[email protected]> wrote: > > These 3rd party files incorrectly have ASF headers. > > ./dev/ci/chart_schema.yaml > >./dev/ci/lintconf.yaml > > These 3rd party files are from > https://github.com/helm/chart-testing/tree/main/etc > > > On Mon, Apr 28, 2025 at 8:29 AM Justin Mclean <[email protected]> > wrote: > > > HI, > > > > -1 (binding) > > > > I checked: > > - incubating in the artifacts' names > > - disclaimer exists > > - there are some license and notice issues (see below) > > - files have ASF headers where needed, but some ASF headers have been > > added to 3rd party files > > - no unexpected binary files in source release > > - can compile from source, but the tests fail > > > > I could start up the server and web UI. > > > > Several files are included in the source release that could be excluded, > > e.g. .github, .asf, yaml, and .gitattributes. Ideally, .gitignore should > > also not be included, but the build script depends on it. > > > > When building the python integration tests failed with this error: > > Execution failed for task ':clients:client-python:integrationTest'. > > > java.io.IOException: Cannot run program > > “.../distribution/package/bin/gravitino.sh": error=2, No such file or > > directory > > > > These 3rd party files incorrectly have ASF headers. > > ./dev/ci/chart_schema.yaml > > ./dev/ci/lintconf.yaml > > > > The source release looks to contain 3rd party code that is not mentioned > > in the license file [1][2]: > > ./core/src/main/java/org/apache/gravitino/listener/api/info/Either.java > > (from AWS SDK Java?, which is Apache licensed) > > > ./lineage/src/test/java/org/apache/gravitino/lineage/source/TestLineageOperations.java > > (OpenLinage, which is Apache license) > > > > The binary release is misisng content from the NOTICE file of OpenLinage > > [3][4]. Assuming OpenLinage code is included in the source release (see > > above) it is also misisng from the source release. > > > > The binary is missing several 3rd party licenses from the Web UI (all MIT > > licensed): [5] > > @ant-design/fast-color > > call-bind-apply-helpers > > call-bound > > dunder-proto > > get-proto > > math-intrinsics > > react-hook-form > > scheduler > > side-channel > > side-channel-list > > side-channel-map > > side-channel-weakmap > > > > There is also a minor issue with version numbers being mixed up in these > > files: > > ./clients/client-python/tests/unittests/test_gravitino_version.py > > > > > ./clients/client-java/src/test/java/org/apache/gravitino/client/TestGravitinoVersion.java > > > > (Note the double version numbers.) > > > > Kind Regards, > > Justin > > > > 1. https://infra.apache.org/licensing-howto.html#guiding > > 2. https://infra.apache.org/licensing-howto.html#alv2-dep > > 3. https://github.com/OpenLineage/OpenLineage/blob/main/NOTICE.txt > > 4. https://infra.apache.org/licensing-howto.html#mod-notice > > 5. https://infra.apache.org/licensing-howto.html#permissive-deps >
