The test has successfully found a failure! Isn’t that interesting! I’m going to have to look more at how we can configure this via .asf.yml…
From: Donal Evans <doev...@vmware.com> Date: Tuesday, January 4, 2022 at 3:20 PM To: dev@geode.apache.org <dev@geode.apache.org> Subject: LGTM as a gating job on PRs not actually gating? I just noticed something when reviewing a PR. We recently voted to make the LGTM check a required precheckin job, but even if that job finds newly introduced alerts, it doesn't turn red and block the PR. This seems like it's not working as intended. The comment from LGTM showing that there are newly introduced alerts in the PR: https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F7219%23issuecomment-1005181341&data=04%7C01%7Crhoughton%40vmware.com%7Cd6e65375f2f14cb1ecf808d9cfd8d5dd%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637769352482495865%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=ijOnxfdNO7jLa85akx%2BXoiQKteueZOhcfMXbxFN3BKM%3D&reserved=0 The "passing" LGTM job for the PR showing newly introduced alerts: https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F7219%2Fchecks%3Fcheck_run_id%3D4707178926&data=04%7C01%7Crhoughton%40vmware.com%7Cd6e65375f2f14cb1ecf808d9cfd8d5dd%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637769352482495865%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=4nfV3tde3CI79tAm8%2BKN3WYNHo8eWWY%2BePNeAeL204M%3D&reserved=0 I'm not sure what the solution to this is, but it certainly seems like the intended result wasn't achieved when making the LGTM check a required pre-checkin job.
