I just noticed something when reviewing a PR. We recently voted to make the 
LGTM check a required precheckin job, but even if that job finds newly 
introduced alerts, it doesn't turn red and block the PR. This seems like it's 
not working as intended.

The comment from LGTM showing that there are newly introduced alerts in the PR: 
https://github.com/apache/geode/pull/7219#issuecomment-1005181341
The "passing" LGTM job for the PR showing newly introduced alerts: 
https://github.com/apache/geode/pull/7219/checks?check_run_id=4707178926

I'm not sure what the solution to this is, but it certainly seems like the 
intended result wasn't achieved when making the LGTM check a required 
pre-checkin job.

Reply via email to