Hi all,
* We need to discuss how to prevent more flaky tests to be introduced now that stress-test is not mandatory for PRs to be merged? Reviewers checking the PR must check the tests failing in stress test and if it is a test that has been introduced or changed in the PR, the PR must be blocked with a change request or rejected. * Also, in my opinion, we need to re-introduce the stress test as a mandatory check for PRs to be merged once the flaky test percentage has been reduced. Owen, will it be possible to put out a list of all the flaky tests and we can try to get these resolved collectively as a community. (results of the mass tests maybe). Thank you. Regards Nabarun Nag ________________________________ From: Kirk Lund <kl...@apache.org> Sent: Thursday, June 10, 2021 9:37 AM To: dev@geode.apache.org <dev@geode.apache.org> Subject: Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs Ok, I wanted to give this discussion another night and we still have consensus for making both stress-new-test non-required. I just filed PR #6602 <https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F6602&data=04%7C01%7Cnnag%40vmware.com%7C33d0e8c6a7d44c692dd808d92c2e1563%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637589398736131723%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=oxThcHojPNnLZmo8y2wJJDYnZzELNPN6cntY%2FMgvd%2Fw%3D&reserved=0> to change stress-new-test from required to non-required. Please review! On Wed, Jun 9, 2021 at 2:11 PM Anthony Baker <bak...@vmware.com> wrote: > If we have consensus, no need to VOTE. > > > On Jun 9, 2021, at 12:52 PM, Owen Nichols <onich...@vmware.com> wrote: > > > > Ok, I'm on board with changing stress-new-test from a required PR check > to non-required. It's simple, codeowners still have the final say, and it > neatly avoids the whole topic of overrides. Time to take a [VOTE]? > > > >
