+1
I recently ran into some Windows failures related to test ordering and
Integration tests not properly cleaning up after themselves (totally unrelated
to my changes) after merging a PR. If the PR checks had shown these failures,
the underlying issue could have been addressed before merging my changes and
avoided the need to revert.
________________________________
From: Jinmei Liao <jil...@vmware.com>
Sent: Thursday, June 25, 2020 10:01 AM
To: dev@geode.apache.org <dev@geode.apache.org>
Subject: Re: [PROPOSAL] Add windows jobs to PR checks
+1, what was the reason for it not being included the PR before?
________________________________
From: Dick Cavender <di...@vmware.com>
Sent: Thursday, June 25, 2020 9:54 AM
To: dev@geode.apache.org <dev@geode.apache.org>
Subject: RE: [PROPOSAL] Add windows jobs to PR checks
+1
-----Original Message-----
From: Owen Nichols <onich...@vmware.com>
Sent: Thursday, June 25, 2020 9:38 AM
To: dev@geode.apache.org
Subject: Re: [PROPOSAL] Add windows jobs to PR checks
+1 for adding all JDK11 Windows tests to PR pipeline.
On 6/25/20, 9:29 AM, "Kirk Lund" <kl...@apache.org> wrote:
I merged some new AcceptanceTests to develop after having my PR go GREEN.
But now these tests are failing in Windows.
I'd like to propose that we add the Windows jobs to our PR checks if we
plan to keep testing on Windows in CI.
Please vote or discuss.
Thanks,
Kirk
