+1 to add Windows jobs to PR checks (1) I know there are some folks who may be resistant to this for good reasons, but the problem is that what we are currently doing is untenable and wasteful. Every other week, I hit this and then waste a day reverting, fixing, resubmitting.
I don't want to submit more PRs with tests until this is actually resolved because I'm sick of this problem. In order of my preferences: 1) add Windows jobs to PR checks 2) remove Windows jobs from CI if we don't test them in PR (I *NEVER* want to see a *GREEN* PR that then breaks CI) 3) add some new complicated process in which we manually or automatically trigger Windows jobs against a PR *BEFORE* we consider merging it to develop 4) stop writing new tests or editing existing tests that might fail on Windows Thanks, Kirk On Thu, Jun 25, 2020 at 9:29 AM Kirk Lund <kl...@apache.org> wrote: > I merged some new AcceptanceTests to develop after having my PR go GREEN. > But now these tests are failing in Windows. > > I'd like to propose that we add the Windows jobs to our PR checks if we > plan to keep testing on Windows in CI. > > Please vote or discuss. > > Thanks, > Kirk >
