Thanks for clarifying, Mark. Let's wait for all the approvals and test results before back-porting to 1.13.
On Tue, Jun 16, 2020 at 2:16 PM Mark Hanson <hans...@vmware.com> wrote: > Hi Dave, > > So this PR is actually awaiting some reviews before it will be put on > develop. > > Thanks, > Mark > > On 6/16/20, 2:07 PM, "Dave Barnes" <dbar...@apache.org> wrote: > > If I understand correctly that the refactored version has already been > checked in and tested on `develop`, then we have enough approvals to > add > this to 1.13. > Go ahead, Mark. > > On Tue, Jun 16, 2020 at 8:45 AM Joris Melchior <jmelch...@vmware.com> > wrote: > > > Yes, +1 on this change. > > > > Joris > > ________________________________ > > From: Mark Hanson <hans...@vmware.com> > > Sent: June 15, 2020 16:30 > > To: dev@geode.apache.org <dev@geode.apache.org> > > Subject: Re: Refactor to Restore Redundancy Command for 1.13? > > > > To be clear the code for 1.13 using the Restore Redundancy Command > in GFSH > > is fine as it stands. We are refactoring to add the REST API version. > > > > Are people still good with that? > > > > Thanks, > > Mark > > > > On 6/15/20, 1:28 PM, "Kirk Lund" <kl...@apache.org> wrote: > > > > +1 for getting the change into 1.13 > > > > On Mon, Jun 15, 2020 at 1:25 PM Owen Nichols < > onich...@vmware.com> > > wrote: > > > > > +1 for getting it right the first time > > > > > > > > > --- > > > Sent from Workspace ONE Boxer< > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwhatisworkspaceone.com%2Fboxer&data=02%7C01%7Chansonm%40vmware.com%7C774b45ee83db4e6a5a5a08d812394116%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637279384406586799&sdata=vcdgVzwoT7OO7%2BJJC1s6U8VVO2lpg0rYFCLSMHR9Kq4%3D&reserved=0 > > > > > > > > > On June 15, 2020 at 1:23:59 PM PDT, Mark Hanson < > hans...@vmware.com> > > > wrote: > > > Hi All, > > > > > > So we are working on refactoring the Restore Redundancy gfsh > command > > code > > > and we have made a change to a class that is getting > serialized. We > > are > > > curious if this is something we could maybe get into 1.13 ( > the first > > > release of this command? Or should we just make our > > > serialization/deserialization work for 2 versions? > > > > > > Thanks, > > > Mark > > > > > > > > >
