+1 for making it simpler for upgrade. ________________________________ From: Owen Nichols <[email protected]> Sent: Monday, June 15, 2020 1:41 PM To: [email protected] <[email protected]> Subject: Re: Refactor to Restore Redundancy Command for 1.13?
There is precedent[1] for bringing a refactoring to a support branch prior to initial release of that feature. The window is still open, and backporting will keep that serialization code that much simpler for the future. You have two +1's already, you just need one more __ [1] https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmail-archives.apache.org%2Fmod_mbox%2Fgeode-dev%2F202002.mbox%2F%253cdd059468-0ac6-7ade-b783-2e538d90a055%40apache.com%253e&data=02%7C01%7Cjiliao%40vmware.com%7Cee776e6ba2d54e06260a08d8116caf3b%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637278505778224125&sdata=7yMFnw8HxBz4hMyoXj9%2Bzl8l%2BOBEB2SgiqZrYa7Urrg%3D&reserved=0 On 6/15/20, 1:30 PM, "Mark Hanson" <[email protected]> wrote: To be clear the code for 1.13 using the Restore Redundancy Command in GFSH is fine as it stands. We are refactoring to add the REST API version. Are people still good with that? Thanks, Mark On 6/15/20, 1:28 PM, "Kirk Lund" <[email protected]> wrote: +1 for getting the change into 1.13 On Mon, Jun 15, 2020 at 1:25 PM Owen Nichols <[email protected]> wrote: > +1 for getting it right the first time > > > --- > Sent from Workspace ONE Boxer<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwhatisworkspaceone.com%2Fboxer&data=02%7C01%7Cjiliao%40vmware.com%7Cee776e6ba2d54e06260a08d8116caf3b%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637278505778224125&sdata=nd54tfXvwExG%2F6G1ZgmZt50ip4KVLRZBRUbY6BN0B2s%3D&reserved=0> > > On June 15, 2020 at 1:23:59 PM PDT, Mark Hanson <[email protected]> > wrote: > Hi All, > > So we are working on refactoring the Restore Redundancy gfsh command code > and we have made a change to a class that is getting serialized. We are > curious if this is something we could maybe get into 1.13 ( the first > release of this command? Or should we just make our > serialization/deserialization work for 2 versions? > > Thanks, > Mark >
