+1 on the assignee idea but understand Mark's concerns with inundating certain people. Is there a way that we can manage the load for reviewers?
On Tue, Jul 9, 2019 at 2:17 PM Mark Hanson <mhan...@pivotal.io> wrote: > In Github there is a request re-review option. I just learned more about > that today. > I think that people should probably be using that option to interact with > reviewers. > I do like the assignee idea. I worry that things might pile up on certain > people, > but that already kind of happening because certain people are doing more > reviews. > > Thanks, > Mark > > > > On Jul 9, 2019, at 11:09 AM, Benjamin Ross <br...@pivotal.io> wrote: > > > > +1 > > > > I think having an assignee would help set better expectations between > > committer and reviewer. > > > > On Tue, Jul 9, 2019 at 11:05 AM Dan Smith <dsm...@pivotal.io> wrote: > > > >> +1 > >> > >> What do you think about assigning someone to each PR to make sure it > gets > >> through the process? We don't currently seem to be using github's > >> "assignee" field. Committers can make themselves the assignee, but for > >> contributors we could assign a committer who will make sure the PR gets > >> reviewed and merged in a timely fashion. > >> > >> -Dan > >> > >> On Tue, Jul 9, 2019 at 10:34 AM Mark Hanson <mhan...@pivotal.io> wrote: > >> > >>> Hi All, > >>> > >>> TL;DR > >>> > >>> Can we have a norm( preferred, but not required ) of providing feedback > >>> within seven days of the last checkin to a PR? > >>> > >>> Long version > >>> > >>> I have just spent a bit of time reviewing PRs that have been open for a > >>> while and sent some emails to reviewers of the ones that are open the > >>> longest. In my humble opinion, it would be very nice if we could close > >> out > >>> some of the older PRs where the requester has made changes to, but > >>> reviewers have not re-reviewed. An ideal norm would seem to be 7 days. > >> One > >>> might notice that I have a PR that I requested a change on, that I have > >> not > >>> provided feedback on, so I am in the same boat... > >>> > >>> Thoughts? > >>> > >>> Thanks, > >>> Mark > >> > > -- *Joris Melchior * CF Engineering Pivotal Toronto 416 877 5427 “Programs must be written for people to read, and only incidentally for machines to execute.” – *Hal Abelson* <https://en.wikipedia.org/wiki/Hal_Abelson>
