+1 I think it will help keep people engaged. It's no fun when your PR is left to hang and might discourage infrequent/new contributors.
On Tue, Jul 9, 2019 at 1:34 PM Mark Hanson <mhan...@pivotal.io> wrote: > Hi All, > > TL;DR > > Can we have a norm( preferred, but not required ) of providing feedback > within seven days of the last checkin to a PR? > > Long version > > I have just spent a bit of time reviewing PRs that have been open for a > while and sent some emails to reviewers of the ones that are open the > longest. In my humble opinion, it would be very nice if we could close out > some of the older PRs where the requester has made changes to, but > reviewers have not re-reviewed. An ideal norm would seem to be 7 days. One > might notice that I have a PR that I requested a change on, that I have not > provided feedback on, so I am in the same boat... > > Thoughts? > > Thanks, > Mark -- *Joris Melchior * CF Engineering Pivotal Toronto 416 877 5427 “Programs must be written for people to read, and only incidentally for machines to execute.” – *Hal Abelson* <https://en.wikipedia.org/wiki/Hal_Abelson>
