Github user jinmeiliao commented on a diff in the pull request:

    https://github.com/apache/geode/pull/745#discussion_r135635795
  
    --- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShowMetricsCommand.java
 ---
    @@ -794,7 +84,7 @@ public Result showMetrics(
           }
           if (regionName != null && !regionName.isEmpty()) {
     
    -        if 
(!org.apache.geode.internal.lang.StringUtils.isBlank(cacheServerPortString)) {
    +        if (!StringUtils.isBlank(cacheServerPortString)) {
    --- End diff --
    
    Let's leave these things for other cleanup tasks. The focus of this change 
set is to break these command into separate classes. I know we all can't resist 
the urge of making everything perfect from time to time, but one thing at a 
time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to