Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/745#discussion_r135629055
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateRegionCommand.java
---
@@ -247,7 +207,7 @@ public Result createRegion(
new Object[] {CliStrings.CREATE_REGION__USEATTRIBUTESFROM,
useAttributesFrom}));
--- End diff --
Bit of a nit-pick, but we have been trying to clean up these cases where we
unnecessarily create new object arrays to pass to varargs methods. This occurs
several places in the class
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
