Github user PurelyApplied commented on a diff in the pull request:
https://github.com/apache/geode/pull/730#discussion_r135625773
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/domain/DataCommandResult.java
---
@@ -415,9 +413,8 @@ public Result toCommandResult() {
toCommandResult_isPut(section, table);
} else if (isRemove()) {
toCommandResult_isRemove(section, table);
- } else if (isSelect()) {
- // its moved to its separate method
}
+ // isSelect() moved to a separate method
--- End diff --
It was a little intentional to leave it. In the context, I couldn't tell
if it was actually helpful to explicitly comment that "No, we didn't forget
about `isSelect()`", but I also didn't investigate too closely to see why
`toCommandResult()` necessarily won't git on a select command.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
