Github user PurelyApplied commented on a diff in the pull request:
https://github.com/apache/geode/pull/730#discussion_r134618712
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/result/AbstractResultData.java
---
@@ -147,11 +147,10 @@ public ResultData addAsFile(String fileName, String
fileContents, String message
public ResultData addAsFile(String fileName, byte[] data, int fileType,
String message,
boolean addTimeStampToName) {
- byte[] bytes = data;
--- End diff --
I might by projecting my Python and C expectations into my relatively new
Java experience, but I thought this assignment wouldn't change the mutability
of `data`. Wouldn't this need `byte[] bytes = data.clone();` to actually
provided immutability to `data`? Or is Java more defensive than I realized?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
