----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61701/ -----------------------------------------------------------
(Updated Aug. 24, 2017, 10:02 p.m.) Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Kirk Lund, and Patrick Rhomberg. Changes ------- Additional changes in the launchers due to tests that were failing from expected/actual mismatches of localhost address in LocatorLauncherRemoteIntegrationTest and ServerLauncherRemoteIntegrationTest. Fixed a bug in LocatorLauncher.LocatorState.getBindAddressAsString(), apparently from when legacy code was open sourced and geode's StringUtils was replaced by the StringUtils in Apache Commons. (!StringUtils.isBlank) was at some point copy/pasted incorrectly without the '!'. Updated tests ```*LauncherRemoteIntegrationTest``` to take into account the updated information in the LocatorState & ServerState classes. Repository: geode Description ------- Updated tests for changes in the error constructors for ServerState and LocatorState. Minor spelling corrections. Diffs (updated) ----- geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StatusLocatorRealGfshTest.java 3a98373938e3de21da6badcf460dae3648218ac6 geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java 83c1ab533e3dea323a8a99f7002b9464a54dfc25 geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java ae64691605130c9b212a3a33bb65ae37b28af02b geode-core/src/test/java/org/apache/geode/distributed/LauncherIntegrationTestCase.java 409a96dbe416a6f96c2389356b9d823d1adb793f geode-core/src/test/java/org/apache/geode/distributed/LocatorLauncherRemoteIntegrationTest.java cc42a53772f3064b800ca1ac1ae894be6c715399 geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherRemoteIntegrationTest.java 733a1082ae9993fbdb646712380af7dcc1cca560 geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/lifecycle/GfshStatusCommandsIntegrationTest.java dd5841f4cffca38da07a11f381cf4174d7264349 geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java e7f17ef208a1708f385c7c4041affb70fd309a4c Diff: https://reviews.apache.org/r/61701/diff/5/ Changes: https://reviews.apache.org/r/61701/diff/4-5/ Testing (updated) ------- Precheckin from earlier ran green. 8/23/17: Re-running precheckin with this additional refactoring. 8/24/17: Once more around the precheckin merry-go-round Thanks, Ken Howe
