----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61701/#review183145 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java Lines 2017 (patched) <https://reviews.apache.org/r/61701/#comment259161> I think this double-ternary might be easier to read if we split it up into a few separate statements. geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/lifecycle/GfshStatusCommandsIntegrationTest.java Lines 85 (patched) <https://reviews.apache.org/r/61701/#comment259162> Looks like you intended to uncomment this line. - Jared Stewart On Aug. 16, 2017, 9:21 p.m., Ken Howe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61701/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2017, 9:21 p.m.) > > > Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Kirk Lund, > and Patrick Rhomberg. > > > Repository: geode > > > Description > ------- > > Updated tests for changes in the error constructors for ServerState and > LocatorState. > > Minor spelling corrections. > > I've updated the fix for GEODE-3277 and rebased on top of the @klund's recent > process controller updates > > > Diffs > ----- > > > geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StatusLocatorRealGfshTest.java > 3a98373938e3de21da6badcf460dae3648218ac6 > geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java > 83c1ab533e3dea323a8a99f7002b9464a54dfc25 > geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java > ae64691605130c9b212a3a33bb65ae37b28af02b > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/lifecycle/GfshStatusCommandsIntegrationTest.java > dd5841f4cffca38da07a11f381cf4174d7264349 > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java > e7f17ef208a1708f385c7c4041affb70fd309a4c > > > Diff: https://reviews.apache.org/r/61701/diff/1/ > > > Testing > ------- > > Precheckin is in progress. > > > Thanks, > > Ken Howe > >
