----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60875/#review181388 -----------------------------------------------------------
Ship it! Ship It! - Darrel Schneider On July 25, 2017, 12:03 p.m., Lynn Gallinat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60875/ > ----------------------------------------------------------- > > (Updated July 25, 2017, 12:03 p.m.) > > > Review request for geode, anilkumar gingade, Darrel Schneider, and Dan Smith. > > > Repository: geode > > > Description > ------- > > An online backup was not taking a snapshot of a single point in time. The > solution is for operations that change the disk files to acquire the backup > lock, causing them to wait until backup has rolled the op logs. > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/internal/cache/BackupLock.java > 4b4fb10 > geode-core/src/main/java/org/apache/geode/internal/cache/DiskInitFile.java > 0925d28 > geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java > 3e97d0e > geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java 5399d5a > > geode-core/src/test/java/org/apache/geode/internal/cache/persistence/BackupPrepareAndFinishMsgDUnitTest.java > PRE-CREATION > > geode-core/src/test/resources/org/apache/geode/codeAnalysis/excludedClasses.txt > db234e0 > > geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedSerializables.txt > e5a111c > > > Diff: https://reviews.apache.org/r/60875/diff/2/ > > > Testing > ------- > > Precheckin. > > > Thanks, > > Lynn Gallinat > >