----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60875/#review180603 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/internal/cache/BackupLock.java Lines 72 (patched) <https://reviews.apache.org/r/60875/#comment255810> This whole backupThread thing is clunky and I think Dan is correct that with the way it is currently implemented it needs to have super.lock. I think it would be better to have the method "setBackupThread(Thread)" to instead be "setBackupThread()" and just have it set a ThreadLocal<Boolean> to true that says the current thread is doing a backup. Add a method "boolean isCurrentThreadDoingBackup()" and it could just call this method. unlockForBackup would unset the thread local. - Darrel Schneider On July 14, 2017, 10:40 a.m., Lynn Gallinat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60875/ > ----------------------------------------------------------- > > (Updated July 14, 2017, 10:40 a.m.) > > > Review request for geode, anilkumar gingade, Darrel Schneider, and Dan Smith. > > > Repository: geode > > > Description > ------- > > An online backup was not taking a snapshot of a single point in time. The > solution is for operations that change the disk files to acquire the backup > lock, causing them to wait until backup has rolled the op logs. > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/internal/cache/BackupLock.java > 4b4fb10 > geode-core/src/main/java/org/apache/geode/internal/cache/DiskInitFile.java > 0925d28 > geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java > 3e97d0e > geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java 5399d5a > > > Diff: https://reviews.apache.org/r/60875/diff/1/ > > > Testing > ------- > > Precheckin. > > > Thanks, > > Lynn Gallinat > >
