----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60935/ -----------------------------------------------------------
(Updated July 21, 2017, 7:18 p.m.) Review request for geode, Darrel Schneider, Eric Shu, Lynn Gallinat, and Nick Reich. Changes ------- Changes as suggested in review comments. Repository: geode Description ------- The pdx registry needs to be persisted to use pdx with persistent region. Currently while creating pdx the system checks, to see if there is a disk store with data instead of looking for persistent region in the system. In cases where persistent region is created and dropped, the system doesn't allow creating pdx witout setting pdx persistence. Diffs (updated) ----- geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java de5fd88 geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java aed439c geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/CacheCreation.java db5f7ca geode-core/src/main/java/org/apache/geode/pdx/internal/PeerTypeRegistration.java 065255b geode-core/src/test/java/org/apache/geode/pdx/PdxAttributesJUnitTest.java ef15cd5 Diff: https://reviews.apache.org/r/60935/diff/2/ Changes: https://reviews.apache.org/r/60935/diff/1-2/ Testing ------- Added new test. Precheckin started. Thanks, anilkumar gingade
