----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60257/#review180087 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/cache/Cache.java Lines 444 (patched) <https://reviews.apache.org/r/60257/#comment255105> I think you should hold off on adding this and propose it on dev@geode. I'd like to see you commit everything else as soon as possible though. - Kirk Lund On June 21, 2017, 3 p.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60257/ > ----------------------------------------------------------- > > (Updated June 21, 2017, 3 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > ------- > > * move the authorize* call to external SecurityService > * Add getSecurityService() that returns the external SecuritySerfice in Cache > * Add a getCache method in FunctionContext > * Add a test to demonstrate the locking in GetRegionFunction and fix it. > > revision 1 is a small changeset that shows all the above. > revision 2 is a simple rename of the internal SecurityService to > InternalSecurityService. It touches a lot of files, but the changes are > pretty autonomous. > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/cache/Cache.java > 66a3cd8097f8b526d0bd69f3afbd2dc55fa1ac3e > geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java > 9b23f6c1a8ed3449d8a49029d6364f1e989e367c > > geode-core/src/main/java/org/apache/geode/cache/execute/FunctionContext.java > 74f05c557d3cd7bc05e0389419ef84e17d797bf4 > > geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java > 15723557915e2b810270ba58a2195d2222da8c68 > > geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberFactory.java > b682d93fd5c4b5340e2c30be72c5572e031e26ed > > geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java > c52ccbc1cc5a293d70b177e38ddddf03dc17c7db > > geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberFactory.java > 01d99951bc70547fb311f2edbfec8dde1be799f7 > > geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java > 2d6af1a22644d427ec2d17863cef27a8d8961491 > > geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java > f895b964794f99127f1f0c9564f3f85213e0af22 > > geode-core/src/main/java/org/apache/geode/internal/cache/CacheServerImpl.java > 7d4b6d4988a836854bc2a54a40c761152a635b14 > > geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java > 5eaa5a4bd237d9d8954ce69323912a6be5139fd0 > geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java > 4c229db09f59deb8d36cc56a532ea0c7d3202977 > > geode-core/src/main/java/org/apache/geode/internal/cache/execute/FunctionContextImpl.java > 39190f3c9d6ff2403542b729ee8d9c254bf6898f > geode-core/src/main/java/org/apache/geode/internal/cache/tier/Command.java > 110d6ef2a59c652cbdc860aad745d123e3b344e5 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java > 2a8818cefedc8bce415b97b18a32ba083ea2f257 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java > cc78cca048c0215c2086fab80e7834419bdf65a6 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommandQuery.java > 184aa36fc5509285001155e20d846cc717544d2f > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientProxy.java > d7e354887b000aad402627acd3b9340d8101e4f8 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/HandShake.java > 32735b9ab17fe9467cea46096bd177902145e4bd > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java > 947b83652803d7b6af9e6157ba84ba842c5da58e > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerHandShakeProcessor.java > 8b896945a8f136b3081df6efec51edec304f3086 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/AddPdxEnum.java > 5a4a07b81b18d33e465bd3aa46ad4232b976b608 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/AddPdxType.java > cb4b261586a3536cfd5609e627a37cbca7ecf81f > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ClearRegion.java > 610af436cd96b0663d69915d8a1b37549e4f7bc2 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ClientReady.java > ae95caec718141e6567cc57cf1c24193210132fc > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/CloseConnection.java > ed050bda24bf6896a0494309edbf90e12e759d24 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/CommitCommand.java > c9987db636d8ff2b01beba1d958d308fdd8430f8 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ContainsKey.java > d7a1b2b0183405142d524c1d91433eb01ac3e9f6 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ContainsKey66.java > 03e798c579e6c26e3aa7cb9a522f8af514f60ce3 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/CreateRegion.java > 2be4724bc2b2b6d472558cdecddba982da032a08 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Default.java > 5bf9d07760b42c562eabf4d979e6e50da4445959 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Destroy.java > cdbab8047558234bd25aa6155a7603a62d697d03 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Destroy65.java > c8b794a9b0b4c223e6391a8e7f63aa0747943417 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyRegion.java > baa2f3f480ce4bea522ea520e86328384cfd2d23 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteFunction.java > 2bfbdb5167a14dd48ab821bf997b5a02193a284a > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteFunction65.java > 167aa3bdb48656c28bad81bed32306dc32094b1e > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteFunction66.java > e212b508be0702e02128b0f91b66fbec9b1887d1 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteFunction70.java > 5299ce4502de2baf0915f36e0e0c96707a6197a0 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteRegionFunction.java > 73eff40c34f6fe882ec1e21168e522ae9ced2736 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteRegionFunction61.java > 8e1e01b064491e282863d60657cd745ed3a48387 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteRegionFunction65.java > 47684aa2fb5d8ec0190f0e047a627c08e77598f1 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteRegionFunction66.java > 26d5d3f31a6b0cf2e2ff1477a2e5e3449fd5453d > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteRegionFunctionSingleHop.java > 8c3bb381fe6e2e9018aaf8c333a3ab0c26127c27 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GatewayReceiverCommand.java > 12e494ab9fdafd353fef48a7002399cce664b0dc > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Get70.java > 62644eb109f661a00c2c4df06e96c8d7a4f8d33f > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetAll.java > e214ce16e4be1f044f40f44308435eec43d1c8ca > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetAll651.java > aacfc6dccd6385ac39a9c2b65ecf6f7456bba704 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetAll70.java > 0449447e3b9e8bd202ed7d14f35d258034f4c861 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetAllWithCallback.java > 9f970a59961c8d10c498f8db6f8cb403036d9f96 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetClientPRMetadataCommand.java > 67a8fa613338751e77e6786e68363ece733d50e2 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetClientPRMetadataCommand66.java > a7aa2ad09fcc1535d523d62ba175f3ea7c1a06ee > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetClientPartitionAttributesCommand.java > ded577a693c3a9bb2bad4d37984ad5e1dbfe0a50 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetClientPartitionAttributesCommand66.java > 709cc5e5d17f471303ba23c048846e384a85ad90 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetFunctionAttribute.java > 76cc4a59bff691c4760083861362825d70ba326e > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetPDXEnumById.java > 5e59640e5067ec8ac5fc50807ec276e1bdc025dd > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetPDXIdForEnum.java > b0ebaf23f27e91278c7afe3648954ad6113206a8 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetPDXIdForType.java > caa0661528dc3d3824c60ac540ca77468d010459 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetPDXTypeById.java > e46445bc96d735a66aa09330a1790b951591251e > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetPdxEnums70.java > 3fe9750f8577a70e4cda9e76da83070f6e6606b1 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetPdxTypes70.java > e64683fb620985d698357912bb1d1b52e8b24681 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Invalid.java > 5066b12d31d4803fc6579d07d8c12a2ca772498c > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Invalidate.java > 3952b0f98965c3a56d1c003454c323a55f295f0b > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/KeySet.java > 202d91fc8bbfcd012a7b6c344b3ef39f63b7b81d > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/MakePrimary.java > bc023adec0b08a3c16ccdf7a9f14004cb5ab15ae > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ManagementCommand.java > 2cb33bc0aca2609bad8671df670b84a1d6bf37ea > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/PeriodicAck.java > ff8c9f2c509b6f532fdc50e1134e07b18a6d5b18 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Ping.java > 5408e290fb906d0f458d65add8246a854792421e > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Put.java > 27f8cc564c163a2d1c8448f0c7acb411993e5fc1 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Put61.java > 60870d7eb04067b3ff5540597c403b9a9b491c65 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Put65.java > 8f65b9bd0bdaef161d230fd1ecf47b7efa1be8cf > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/PutAll.java > f8cd57fdfc6cd8aa939d314e94d3c1f38fe90521 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/PutAll70.java > 1bf4955021104986b7c6ac5bc9e6fa1b1085b83b > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/PutAll80.java > 3a8f0db633384f5cdb65405c3bf21d53bed30a0e > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/PutUserCredentials.java > 02ecce08fd52949bb86b826e95b930714c9f5317 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Query.java > d1be0576028164236a1152694a05339676ebb9f3 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Query651.java > d47a2849a57126639b4bc9e678b8311816cbe9c3 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterDataSerializers.java > eef5195eae3bedb414aa2e2fca748b31e0b27908 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInstantiators.java > a402cb360f05f99442833e6098c736d2ac18d69a > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterest.java > a1cf93f15733da95e9b1aea8b709b5d4166b8559 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterest61.java > 111f234130ae4e0733d634714765ebe3c998b49e > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestList.java > c64bc6979da6049c901b34d8aaf0d66a1d26336a > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestList61.java > 82e2f0d7ab79e87bec81da29610016ea8f5eafe6 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestList66.java > 5f6ab9b08fa0873b8dbc7fcd755b1857ffe3770e > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RemoveAll.java > 2daf755ab200d84f0b7760224060439d9e3518f1 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RemoveUserAuth.java > ead54693940f0fc91180d0a38f1338aa3e43b257 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Request.java > 25badd328a5d7edafb81fd3402ebcc47301983d1 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RequestEventValue.java > 0d64747f06459f281ed93d9c87fe5caf9606a7c9 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RollbackCommand.java > 2100c76009fa15b96e26f378b3b06b11a96827a5 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Size.java > e4485b469858881486a588adc627181d093c9949 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/TXFailoverCommand.java > 6bd00c09519feb5e3dbb331c9d7efc171956d252 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/TXSynchronizationCommand.java > b1b0cfbc336c47b87ddc780b62c6064fa595cf1c > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/UnregisterInterest.java > 1af283bbfefee7ff4f855429139aae20076c2d78 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/UnregisterInterestList.java > 035a953fd40d90e5c49f7c53bb997637d3d24c61 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/UpdateClientNotification.java > 8e50f64b61561e60ec791b72b8c93732e6360b03 > > geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/CacheCreation.java > 61f91a04359c2c33f410a907761980df571844ec > > geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java > 171cfb71aa5267822ebc0624a43fb0f79c5c7a97 > > geode-core/src/main/java/org/apache/geode/internal/security/LegacySecurityService.java > c594bf932cad7926287710e705f6381e04604510 > > geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java > feea8995de1ae3ba24d84b4046063ab79e21ec47 > > geode-core/src/main/java/org/apache/geode/internal/security/SecurityServiceFactory.java > 2e0ad956cdc547a836efd0ee43c8cd128c9b263c > > geode-core/src/main/java/org/apache/geode/internal/security/shiro/JMXShiroAuthenticator.java > 4f6c3cf4112402105d5728ad5620cd9aad3cf009 > > geode-core/src/main/java/org/apache/geode/management/internal/ManagementAgent.java > 554dc66ac065474f22add936050f0f9185491186 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DeployCommands.java > 9b79e1d7a94c5e8bbfd4ffd775249739b803621c > > geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/DataCommandFunction.java > 41cc171dbabee2cf51a9e28d051b8365a3c44699 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/GetRegionsFunction.java > d52492466d521fb25f410e7c03b3d9808aabe67c > > geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/CommandProcessor.java > e9c273698a537fc9431ba176b7acf4d6aaf0e064 > > geode-core/src/main/java/org/apache/geode/management/internal/security/AccessControlMBean.java > 7f088ce3958be918580464e1e43a80bc34922be7 > > geode-core/src/main/java/org/apache/geode/management/internal/security/MBeanServerWrapper.java > 47260bc855025864d0def5855eff33d0cdfd6617 > > geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptor.java > 5e502f55e781a5bf3a656d17d0156175088891b2 > geode-core/src/main/java/org/apache/geode/security/SecurityService.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/auth/AbstractGMSAuthenticatorTestCase.java > e8c4e73e8708c3e917ddb48099f65bf315d4c3d4 > > geode-core/src/test/java/org/apache/geode/internal/cache/execute/FunctionExecutionTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionTest.java > 794c61097c9d3fae32714693473aa6b71538c1c7 > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ContainsKey66Test.java > 1d028524ecd6c737fb53f54dcf5c6d5187f15477 > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ContainsKeyTest.java > 0492997533b88bbb73dc7e87d1f641b98f53f684 > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/CreateRegionTest.java > 00420ccf341246ca740c3be0b7ab062fb70ecaaf > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Destroy65Test.java > 729c68b1bf5d2a0e2b8fc634dbf42c989a68eb40 > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyRegionTest.java > bf699be52da630207b542c542aa33ae9798e4000 > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyTest.java > 59958905160ff96fc06a16423c3fb9f801c5b324 > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteFunction65Test.java > c53b0382732a29e64b403e8eb0f914e19de79b84 > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteFunction66Test.java > b2e30f264a76e88e397488609edef135b4a115c2 > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteFunctionTest.java > cfb496069ca95abc67dc6fe84e6eb2f430c09f2c > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Get70Test.java > 78097d2f8d8d5a67ea7fae57d9147e37fc905d25 > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/GetAll651Test.java > 40bfe45396017b9a18a38db5eed2d3eed2fbe0f2 > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/GetAll70Test.java > a3ee2c8b808e0d4906d89d0eec4e8ab249a3f642 > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/GetAllTest.java > ceb8882954e2ad0d1a638e96945976726e728b06 > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/GetAllWithCallbackTest.java > 4497c7fd48349f288f7a4a99ea283aba9f352f91 > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/GetClientPartitionAttributesCommand66Test.java > 0c3433fd2071c1261bd8d1543718603a1aa3d610 > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/GetClientPartitionAttributesCommandTest.java > 7d35d4e501527af0c1e442554d15cf29bb76c3fa > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/InvalidateTest.java > 08e1a29ba4718c936fd953bee87c071a353ce1a1 > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/KeySetTest.java > a4da48f8bc5504df9323be809b1e1145947a9cd7 > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Put61Test.java > bd99e6c261f5c44a74dfc7d8b70e414a29502ed0 > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Put65Test.java > 8d52b8853994e7c2788a3a90de6be3f516358606 > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/PutTest.java > 6f894cf8c9afad5f8f61df40e31ff8a23e5f3596 > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterest61Test.java > 5437f71a3de19bdc74501e5bd0939a6e4cb52ddd > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestList61Test.java > 0ed27a0244c97ea99e1d2e7c54e91fc80b0eeff1 > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestList66Test.java > bae07b456d9d12bc9d4d10ea0af03e63248f6e2b > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestListTest.java > 1074de585dda9963208a20ac8d28c06a8be5d614 > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestTest.java > cd07e71ee7fed541473596067ad7eb636bc17637 > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RemoveAllTest.java > de5a4597cd609d20afdc86fa3adae72d2dae1f50 > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RequestTest.java > bf7badb0fb3d2f5fae87013e1fac9dc4a5e25df2 > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/UnregisterInterestTest.java > 50fb9cd18d45e82a7f04e61aa8dbdbf2b6b3a419 > > geode-core/src/test/java/org/apache/geode/internal/security/SecurityServiceFactoryShiroIntegrationTest.java > e8548ed864c53a95c04740cf275df5930ac19f0d > > geode-core/src/test/java/org/apache/geode/internal/security/SecurityServiceFactoryTest.java > fc4447bb0706530088c318d704dcbc8313162c5f > > geode-core/src/test/java/org/apache/geode/internal/security/SecurityServiceTest.java > 4b7bbfc5a39cc293a9d2846096fbb3f8b2782028 > > geode-core/src/test/java/org/apache/geode/management/internal/security/SecurityServiceWithShiroIniIntegrationTest.java > 86a0ff0ede41f65a7c41c639546768c5c8befe90 > > geode-core/src/test/java/org/apache/geode/security/CacheFactoryWithSecurityObjectTest.java > 94e0be5e0e760cf584b67942aa2e2c943552cd5f > > geode-core/src/test/java/org/apache/geode/security/SecurityManagerLifecycleDistributedTest.java > 872740645cacce5243ec12b5fed457f4a7c51943 > > geode-core/src/test/java/org/apache/geode/security/SecurityManagerLifecycleIntegrationTest.java > f00b03afda012e0a748768141cebc1c984adcb71 > geode-core/src/test/java/org/apache/geode/test/fake/Fakes.java > af38a1c37a090b3c681fc0ddca14e0a728d02057 > > geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/CloseCQ.java > 6748f7d3193babfa668a7ff2846f974f0cdc1cbd > > geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteCQ.java > 04e32f8ded92fe9f3086c8642918bfc60e9b65c8 > > geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteCQ61.java > 77a608c7e65a2030c0037e9f327cf8c17e9313db > > geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetCQStats.java > a37263f11cefbe317d2a24989256d7d5559cf599 > > geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetDurableCQs.java > 1ba5fed2020652b8da58c652640c97cbfcf9dd9f > > geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/MonitorCQ.java > f5e31df988f5955d2fbeef5269a7729ec97c9d03 > > geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/StopCQ.java > a3d51edcc141391e9d818fc0ed7e514d3cb5d6d0 > > geode-cq/src/test/java/org/apache/geode/security/CQPDXPostProcessorDUnitTest.java > c38bd3b79476cf77dcbe7467c38f8d3456a12985 > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/functions/LuceneCreateIndexFunction.java > 5e36efa5e4027072cb996bb237b3c534db580dc1 > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommandsJUnitTest.java > 1adab5ab8ddb1bd8e133d35d1ef9e643ef3c2785 > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/cli/functions/LuceneListIndexFunctionJUnitTest.java > 2d282a3b406134623f414aacaa8b17f3ddd3e00c > geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/Server.java > ad5c0806b5dcfeaa4826c7fb545e7fc65b347b08 > > geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/GeodeAuthenticationProvider.java > 2f307c9065c442d7cdd21c68fea0762e8cf20b0e > > geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/RestSecurityService.java > 04d74ce5d3b52a955c4fcbc92ff200b79d454a46 > > geode-web/src/test/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptorRequestHeaderJUnitTest.java > a58bcbaee89c83826b44ca0e9e8f852d6789eac3 > > > Diff: https://reviews.apache.org/r/60257/diff/2/ > > > Testing > ------- > > precheckin successful > > > Thanks, > > Jinmei Liao > >
