----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60523/#review179202 -----------------------------------------------------------
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRegionRequestOperationHandler.java Lines 39 (patched) <https://reviews.apache.org/r/60523/#comment253796> If the region legitimately doesn't exist, is this really a failure? Maybe we should rename the 'success' field to something like 'found'. geode-protobuf/src/main/proto/region_API.proto Lines 119 (patched) <https://reviews.apache.org/r/60523/#comment253798> I think it'd be cleaner to add these fields to the Region protobuf object (we'd also need to change the GetRegionsResponse to contain strings instead of Regions, which also seems like an improvement). - Brian Rowe On June 28, 2017, 11:06 p.m., Bruce Schuchardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60523/ > ----------------------------------------------------------- > > (Updated June 28, 2017, 11:06 p.m.) > > > Review request for geode, Alexander Murmann, Galen O'Sullivan, Hitesh > Khamesra, Udo Kohlmeyer, and Brian Rowe. > > > Bugs: GEODE-3141 > https://issues.apache.org/jira/browse/GEODE-3141 > > > Repository: geode > > > Description > ------- > > Added a GetRegion(regionName) API. More details about the server region can > be added if needed. This implementation just has a success flag and flag > saying whether the region is destroyed. > > > Diffs > ----- > > > geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java > 4318fb444dd0eb5f5d07175a466e26f03933cc4d > > geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java > 4e76de4a15d1ff0cfeddcc2c7115c7c18c2e14ba > > geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRegionRequestOperationHandler.java > PRE-CREATION > geode-protobuf/src/main/proto/clientProtocol.proto > 0c192950a4e750f7c55e186c18a79a6c52716bf0 > geode-protobuf/src/main/proto/region_API.proto > d3af17acb1ee45c134837c321b2009c8532817cc > geode-protobuf/src/test/java/org/apache/geode/protocol/MessageUtil.java > dc897241fc229da53a5ff7a0e2df1678b8bceb6d > > geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java > 77b984f7e28a7bfa21b8e1c8c6a83467e9a37242 > > geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRegionRequestOperationHandlerJUnitTest.java > e8f1e651a71240474a793d005164df1ba5d4cda7 > > geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRegionsRequestOperationHandlerJUnitTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/60523/diff/1/ > > > Testing > ------- > > new unit tests > > > Thanks, > > Bruce Schuchardt > >
