[
https://issues.apache.org/jira/browse/GEODE-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16037092#comment-16037092
]
ASF GitHub Bot commented on GEODE-2818:
---------------------------------------
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/548#discussion_r120134823
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java
---
@@ -412,7 +411,7 @@ public Result compactDiskStore(
@CliOption(key = CliStrings.COMPACT_DISK_STORE__NAME, mandatory =
true,
optionContext = ConverterHint.DISKSTORE,
help = CliStrings.COMPACT_DISK_STORE__NAME__HELP) String
diskStoreName,
- @CliOption(key = CliStrings.COMPACT_DISK_STORE__GROUP,
+ @CliOption(key = CliStrings.GROUP,
--- End diff --
looks like this can have "groups" as synonym as well. Can you go through
all your changes and make sure that member/group CliOption that take String[]
as the option type needs to have synonym defined. Thanks!
> add alias to any command's options that involves "group", "member", "jar"
> -------------------------------------------------------------------------
>
> Key: GEODE-2818
> URL: https://issues.apache.org/jira/browse/GEODE-2818
> Project: Geode
> Issue Type: New Feature
> Components: docs, gfsh
> Reporter: Jinmei Liao
> Assignee: Emily Yeh
>
> Or anything that would have confusion about if we are going to use singular
> or plural at all.
> 1) add alias for those options
> 2) make sure it parameter type is an array type, some method only accepts a
> string and split it inside the command.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
