[
https://issues.apache.org/jira/browse/GEODE-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021523#comment-16021523
]
ASF GitHub Bot commented on GEODE-2962:
---------------------------------------
Github user dschneider-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/525#discussion_r118057642
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java
---
@@ -485,9 +485,14 @@ public Result compactDiskStore(
memberCompactInfo.clear();
}
String notExecutedMembers =
CompactRequest.getNotExecutedMembers();
+ if (notExecutedMembers != null &&
!notExecutedMembers.isEmpty()) {
+ notExecutedMembers = "but was not send to " +
notExecutedMembers;
+ } else {
+ notExecutedMembers = "all the members";
--- End diff --
I think this log message only needs to say something if
"notExecutedMembers" is not null and not empty.
No need for a message in the else. You will notice that immediately after
this code is a report of what was compacted so it seem to me too verbose to say
"I sent the request to everyone".
But it could be helpful to log a note of the members that did not receive
the request.
So I think you should put the log lines 493-496 inside this if and get rid
of the else.
> Need more friendly locator's log message when executing "gfsh compact
> disk-store" command
> -----------------------------------------------------------------------------------------
>
> Key: GEODE-2962
> URL: https://issues.apache.org/jira/browse/GEODE-2962
> Project: Geode
> Issue Type: Wish
> Components: persistence
> Reporter: Akihiro Kitada
> Priority: Minor
>
> When executing "gfsh compact disk-store" command, then we currently see the
> following kind of issue if the command is successfully executed for all the
> target members.
> {noformat}
> compact disk-store "DEFAULT" message was scheduled to be sent to but was not
> send to null
> {noformat}
> This message is not friendly to know what was going on.
> Need more friendly log message.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
