[
https://issues.apache.org/jira/browse/GEODE-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16019889#comment-16019889
]
ASF GitHub Bot commented on GEODE-2953:
---------------------------------------
Github user PurelyApplied commented on the issue:
https://github.com/apache/geode/pull/522
Please review the diff, or run a regex search matching `import .*\*;\n`.
This regex hits 1024 occurrences in production and 2205 occurrences in test
code.
Some of these occurrences are commented out. Matching `^import .*\*;\n`
hits 827 production and 2175 test occurrences.
1388 classes going against best practices is indeed alarming, but I do not
believe it is incorrect.
> Code Cleanup: Replace wildcard imports with explicit imports
> ------------------------------------------------------------
>
> Key: GEODE-2953
> URL: https://issues.apache.org/jira/browse/GEODE-2953
> Project: Geode
> Issue Type: Improvement
> Components: general
> Reporter: Patrick Rhomberg
> Assignee: Patrick Rhomberg
> Priority: Minor
>
> While optimal import order may be a matter of debate, all style guides seem
> to agree that wildcard imports should be avoided for improved readability and
> namespace cleanliness.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
