[
https://issues.apache.org/jira/browse/GEODE-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017848#comment-16017848
]
ASF GitHub Bot commented on GEODE-2953:
---------------------------------------
GitHub user PurelyApplied opened a pull request:
https://github.com/apache/geode/pull/522
GEODE-2953: Imports optimized in every file with a wildcard import.
This is a purely semantic change. Imports have been optimized by my IDE.
This may have the side-effect of changing some imports to static imports where
applicable, as well as the ongoing disagreement between IntelliJ and Eclipse as
to where `java` and `javax` imports belong.
All the same, precheckin up and running. Tests and Legacy already back
green.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PurelyApplied/geode geode-2953
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/522.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #522
----
commit fc6ceffec0931575c9150087d11e7083fe9481c5
Author: Patrick Rhomberg <[email protected]>
Date: 2017-05-19T18:18:47Z
GEODE-2953: Imports optimized in every file with a wildcard import.
----
> Code Cleanup: Replace wildcard imports with explicit imports
> ------------------------------------------------------------
>
> Key: GEODE-2953
> URL: https://issues.apache.org/jira/browse/GEODE-2953
> Project: Geode
> Issue Type: Improvement
> Components: general
> Reporter: Patrick Rhomberg
> Assignee: Patrick Rhomberg
> Priority: Minor
>
> While optimal import order may be a matter of debate, all style guides seem
> to agree that wildcard imports should be avoided for improved readability and
> namespace cleanliness.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
