> On April 24, 2017, 9:43 p.m., Jason Huynh wrote: > > geode-core/src/test/java/org/apache/geode/internal/cache/PartitionListenerDUnitTest.java > > Lines 149 (patched) > > <https://reviews.apache.org/r/58628/diff/3/?file=1697557#file1697557line149> > > > > If afterSecondary is invoked more than once, do we want the test to > > fail?
I would rather test to fail if multiple afterSecondary callbacks are invoked. At least it will be a performance issue, why a bucket on a node lost primary twice? If this happens, I think we may need to investage further. - Eric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58628/#review172862 ----------------------------------------------------------- On April 21, 2017, 9:14 p.m., Eric Shu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58628/ > ----------------------------------------------------------- > > (Updated April 21, 2017, 9:14 p.m.) > > > Review request for geode, anilkumar gingade, Darrel Schneider, Jason Huynh, > and Lynn Gallinat. > > > Bugs: GEODE-2785 > https://issues.apache.org/jira/browse/GEODE-2785 > > > Repository: geode > > > Description > ------- > > Verify that all buckets lost primary get the afterSecondary callbacks. > > > Diffs > ----- > > > geode-core/src/test/java/org/apache/geode/internal/cache/PartitionListenerDUnitTest.java > 7fd470f > > > Diff: https://reviews.apache.org/r/58628/diff/3/ > > > Testing > ------- > > precheckin > > > Thanks, > > Eric Shu > >
